From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Subject: Re: [PATCH] hw/block/nvme: remove description for zoned.append_size_limit
Date: Tue, 30 Mar 2021 10:19:54 +0000 [thread overview]
Message-ID: <YGL7SOSqHG6WSshj@x1-carbon.lan> (raw)
In-Reply-To: <YFnPAKkbw3bkB6n5@apples.localdomain>
On Tue, Mar 23, 2021 at 12:20:32PM +0100, Klaus Jensen wrote:
> On Mar 23 11:18, Niklas Cassel wrote:
> > From: Niklas Cassel <niklas.cassel@wdc.com>
> >
> > The description was originally removed in commit 578d914b263c
> > ("hw/block/nvme: align zoned.zasl with mdts") together with the removal
> > of the zoned.append_size_limit parameter itself.
> >
> > However, it was (most likely accidentally), re-added in commit
> > f7dcd31885cb ("hw/block/nvme: add non-mdts command size limit for verify").
> >
> > Remove the description again, since the parameter it describes,
> > zoned.append_size_limit, no longer exists.
> >
> > Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> > ---
> > hw/block/nvme.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> > index 6842b01ab5..205d3ec944 100644
> > --- a/hw/block/nvme.c
> > +++ b/hw/block/nvme.c
> > @@ -91,14 +91,6 @@
> > * the minimum memory page size (CAP.MPSMIN). The default value is 0 (i.e.
> > * defaulting to the value of `mdts`).
> > *
> > - * - `zoned.append_size_limit`
> > - * The maximum I/O size in bytes that is allowed in Zone Append command.
> > - * The default is 128KiB. Since internally this this value is maintained as
> > - * ZASL = log2(<maximum append size> / <page size>), some values assigned
> > - * to this property may be rounded down and result in a lower maximum ZA
> > - * data size being in effect. By setting this property to 0, users can make
> > - * ZASL to be equal to MDTS. This property only affects zoned namespaces.
> > - *
> > * nvme namespace device parameters
> > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > * - `subsys`
> > --
> > 2.30.2
>
> Argh. Thanks Niklas, queing it up for fixes.
>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
I don't see it in nvme-fixes yet.
Did it get stuck in purgatory? ;)
Kind regards,
Niklas
next prev parent reply other threads:[~2021-03-30 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 11:18 [PATCH] hw/block/nvme: remove description for zoned.append_size_limit Niklas Cassel
2021-03-23 11:20 ` Klaus Jensen
2021-03-30 10:19 ` Niklas Cassel [this message]
2021-03-30 12:38 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGL7SOSqHG6WSshj@x1-carbon.lan \
--to=niklas.cassel@wdc.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).