From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3583BC433C1 for ; Tue, 30 Mar 2021 12:45:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 869BF619A7 for ; Tue, 30 Mar 2021 12:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 869BF619A7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRDkQ-0003vw-AK for qemu-devel@archiver.kernel.org; Tue, 30 Mar 2021 08:45:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRDe9-0000bm-3F; Tue, 30 Mar 2021 08:39:01 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRDe5-0002jj-GQ; Tue, 30 Mar 2021 08:39:00 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0B3955C016A; Tue, 30 Mar 2021 08:38:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 30 Mar 2021 08:38:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=UB0Fz5PQIDlTk51X+9qMCM7jri8 Dj6070Pc+UCesGg4=; b=L/ajXCggA/4oebV6c7R2IZcS99p9nmvdVTPZNzh6HGx DlrsckPb6JUa0PnJztEVE8TyCiefZiJ+01SqpLj0iJHbNtJgTRQjovKVSSXwmMUo naUwKlCFoV8bKHV9YLcg1osQucY1suCzhabZGVE+MgCD33gOhh2mv6OaUnCAupMM cF+0Iy4Dpe1hQ0P58NNll1MMAFR0rD6suHqG7PBkNsmFXiorzP6rten2wORKaEDX TFmvebrxBsvL4UeAxsnEMrlLB5Uv2jSjyQOsMZQ5BZqt+F6JtADIyXpcSLNdPGgo mLcMTmcAX1daq8x7uPK6/cBR7USe66d1k8w+rEESnMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=UB0Fz5 PQIDlTk51X+9qMCM7jri8Dj6070Pc+UCesGg4=; b=E/Dg2rYmfe6GysBQvoXovi uJ+aC06e2USKIGlNq/KmW8a/xliBgMjgcwMK4g/tS4h+sx+LRIyrfmCCJgYLEW72 bmko4OZ7pWVB1dtRyPEJ3n3StoGodu+LxteQUw0gO4W82cFGixF64GNwpf1oXe0h ASMWmB1cJ98k274KKnIzEbrGHoLptS8hIYgJjqSsZ7wDaSXm7rnthr5jtrcCHR1s er9cVmi+I1mxC9G/1/uNUzcqEKqU/OoH8BLQWQlxLFeHQfv1/BAgrn4A2dbPD2aL HQP04hCijvIZTpdAijh0IgG5jjpOJtl5weck/Y/LjGW5F41Hy7dmfzNYPFCshHgA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeitddgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgeduffeuieetkeeileekvdeuleetveejudeileduffefjeegfffhuddvudff keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 72CD51080063; Tue, 30 Mar 2021 08:38:53 -0400 (EDT) Date: Tue, 30 Mar 2021 14:38:50 +0200 From: Klaus Jensen To: Niklas Cassel Subject: Re: [PATCH] hw/block/nvme: remove description for zoned.append_size_limit Message-ID: References: <20210323111817.115837-1-Niklas.Cassel@wdc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YB4i9BpFUeBwAJx+" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.25; envelope-from=its@irrelevant.dk; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kbusch@kernel.org" , "qemu-devel@nongnu.org" , "qemu-block@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --YB4i9BpFUeBwAJx+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 30 10:19, Niklas Cassel wrote: > On Tue, Mar 23, 2021 at 12:20:32PM +0100, Klaus Jensen wrote: > > On Mar 23 11:18, Niklas Cassel wrote: > > > From: Niklas Cassel > > >=20 > > > The description was originally removed in commit 578d914b263c > > > ("hw/block/nvme: align zoned.zasl with mdts") together with the remov= al > > > of the zoned.append_size_limit parameter itself. > > >=20 > > > However, it was (most likely accidentally), re-added in commit > > > f7dcd31885cb ("hw/block/nvme: add non-mdts command size limit for ver= ify"). > > >=20 > > > Remove the description again, since the parameter it describes, > > > zoned.append_size_limit, no longer exists. > > >=20 > > > Signed-off-by: Niklas Cassel > > > --- > > > hw/block/nvme.c | 8 -------- > > > 1 file changed, 8 deletions(-) > > >=20 > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > > index 6842b01ab5..205d3ec944 100644 > > > --- a/hw/block/nvme.c > > > +++ b/hw/block/nvme.c > > > @@ -91,14 +91,6 @@ > > > * the minimum memory page size (CAP.MPSMIN). The default value is= 0 (i.e. > > > * defaulting to the value of `mdts`). > > > * > > > - * - `zoned.append_size_limit` > > > - * The maximum I/O size in bytes that is allowed in Zone Append co= mmand. > > > - * The default is 128KiB. Since internally this this value is main= tained as > > > - * ZASL =3D log2( / ), some values= assigned > > > - * to this property may be rounded down and result in a lower maxi= mum ZA > > > - * data size being in effect. By setting this property to 0, users= can make > > > - * ZASL to be equal to MDTS. This property only affects zoned name= spaces. > > > - * > > > * nvme namespace device parameters > > > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > * - `subsys` > > > --=20 > > > 2.30.2 > >=20 > > Argh. Thanks Niklas, queing it up for fixes. > >=20 > > Reviewed-by: Klaus Jensen >=20 > I don't see it in nvme-fixes yet. >=20 > Did it get stuck in purgatory? ;) >=20 >=20 I could have included it for the PULL from yesterday, but I kinda forgot and only added the coverity fixes. That's pulled now, so I've queued it up for the next round of fixes now! :) Thanks for following up on it! --YB4i9BpFUeBwAJx+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmBjG9gACgkQTeGvMW1P DemO6Qf+KxaiT6NE/g3/m8gq9mOt041vWJyKxKtvEN/vBo7X42aZqWWdhPzqKtYP G3PCcUQ1/DRPuqzY5e1zJUbna2LVWk5WzLsNvCHVr3gMTkSITKaRUv8tSXQni5+g WiQzsfcLPQcPX+gVhnQ+JrcxoNOmmNP2mjNmyr03mIXGk40x6wVOGJPWgmCWbTeZ iTBl9PKWY4oTQXFgjVZiJ6Rbkdj37eKyhdrF6ALrC5EKbwMCXw8bP8ZKsmUWFY/6 HMl4d4ylKXqlfoegBDBXfuDSQkaT3jd2NECZ+IS+Ctfz063NWnA9SyzftGN3TI2A +gZgclOvAyFjP2kZINSVp/OdEhg7jA== =/Qz7 -----END PGP SIGNATURE----- --YB4i9BpFUeBwAJx+--