qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: lagarcia@linux.ibm.com
Cc: farosas@br.ibm.com, gkurz@redhat.com,
	Leonardo Garcia <lagarcia@br.ibm.com>,
	qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [PATCH v2] IOMMU not supported by vhost-user.
Date: Wed, 31 Mar 2021 10:14:10 +0100	[thread overview]
Message-ID: <YGQ9YhTALf+KSvCf@stefanha-x1.localdomain> (raw)
In-Reply-To: <a47b7a5dafcab0f3a662414ba6cbbc7eb280d478.1613591341.git.lagarcia@br.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Wed, Feb 17, 2021 at 04:55:12PM -0300, lagarcia@linux.ibm.com wrote:
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 2fdd5daf74..6ab760364b 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -1849,6 +1849,13 @@ static int vhost_user_backend_init(struct vhost_dev *dev, void *opaque)
>              }
>          }
>  
> +        if ((dev->vdev != NULL) &&
> +            virtio_host_has_feature(dev->vdev, VIRTIO_F_IOMMU_PLATFORM) &&
> +            !(features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) {
> +            error_report("IOMMU is currently not supported with vhost-user");

I think IOMMU *is* supported by vhost-user. It's just that specific
vhost-user backends might not implement it.

This error message can be made more specific:

  error_report("IOMMU is not supported by the connected vhost-user backend");

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2021-03-31  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 19:55 [PATCH v2] IOMMU not supported by vhost-user lagarcia
2021-02-23 15:55 ` Greg Kurz
2021-03-31  9:11   ` Stefan Hajnoczi
2021-03-31  9:14 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGQ9YhTALf+KSvCf@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=farosas@br.ibm.com \
    --cc=gkurz@redhat.com \
    --cc=lagarcia@br.ibm.com \
    --cc=lagarcia@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).