From: David Gibson <email@example.com> To: Bruno Piazera Larsen <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org>, Lucas Mateus Martins Araujo e Castro <email@example.com>, Fernando Eckhardt Valle <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Andre Fernando da Silva <email@example.com>, Matheus Kowalczuk Ferst <firstname.lastname@example.org>, Luis Fernando Fujita Pires <email@example.com> Subject: Re: Discussion: Patch series that adds disable-tcg option for ppc targets Date: Tue, 6 Apr 2021 16:11:30 +1000 [thread overview] Message-ID: <YGv7ku+6XNMW1QFM@yekko.fritz.box> (raw) In-Reply-To: <CP2PR80MB44990766F1D104E630ADFDDAC7779@CP2PR80MB4499.lamprd80.prod.outlook.com> [-- Attachment #1: Type: text/plain, Size: 2585 bytes --] On Mon, Apr 05, 2021 at 01:32:18PM +0000, Bruno Piazera Larsen wrote: > Hi all, > > The team I'm working on started to work on adding support for > building the ppc target with the disable-tcg option. However, we're > not quite sure on where to start with such a big patch. > > * Should we focus first on changing the .c files, so that it > will build when we finally patch the meson.build everything > build correctly? Or should we start by changing the meson > file, so that everyone agrees that the excluded files can > indeed be excluded? It's usually best to focus on logical changes, rather than file-by-file. That said, I'd probably suggest changing the .c files first, then changing the meson file. > * Should we first finish the whole series to then mail it, or > should we send one file at a time, as soon as we have them > ready? I'd lean towards building a whole series, since I think the individual file changes won't make a lot of sense on their own. That said, it's ok and encouraged to post a relatively early draft of the series as an RFC, so that the overall idea can be reviewed, even if it has obvious omissions (just mention them in the cover letter). > So far we're thinking we'll need to: > * change 6 files (arch_dump.c, machine.c, mmu-hash32.c, > mmu-hash64.c, mmu-radix64.c and meson.build); I'd expect mmu-*.c to be excluded. Those are softmmu implementations which shouldn't be used with KVM. It's possible there are a few helpers that will need to be extracted, though. You'll probably also need changes in hw/ppc/spapr_hcall.c and maybe some other parts of the spapr code: there are a number of hypercalls that we implement in qemu for TCG, but which are (and must be) implemented in KVM when KVM is in use. So, I expect you'll need to suppress compilation of h_enter, h_remove, h_protect, h_read and h_bulk_remove at least in the !TCG case. > * exclude 8 files from the build (dfp_helper.c, excp_helper.c, > fpu_helper.c, int_helper.c, mem_helper.c, misc_helper.c, * > translate.c, timebase_helper.c); That looks about right. > * create a new one that holds stubs. Sounds reasonable. > Does this sound about right? This is mostly guesswork based on how > x86, s390x and ARM are doing it. Sounds fine so far. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-06 6:13 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-05 13:32 Bruno Piazera Larsen 2021-04-06 6:11 ` David Gibson [this message] 2021-04-10 5:43 ` Thomas Huth 2021-04-06 18:38 Bruno Piazera Larsen 2021-04-06 20:48 ` Fabiano Rosas 2021-04-07 3:01 ` David Gibson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YGv7ku+6XNMW1QFM@yekko.fritz.box \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Discussion: Patch series that adds disable-tcg option for ppc targets' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).