From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA405C433B4 for ; Tue, 20 Apr 2021 09:27:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1852461042 for ; Tue, 20 Apr 2021 09:27:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1852461042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYmer-0004Px-G1 for qemu-devel@archiver.kernel.org; Tue, 20 Apr 2021 05:27:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYmdV-0003Zv-K1 for qemu-devel@nongnu.org; Tue, 20 Apr 2021 05:25:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYmdN-0003JV-1M for qemu-devel@nongnu.org; Tue, 20 Apr 2021 05:25:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618910728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dPQQyrLV04icCx35hxkY23tbdeiAU/IMxvIn/4gETQc=; b=MxEB4fNzRFI5mdiirjc01kHROqJuKfyv5nLyoru0hnxfaHxoVMyrkVtZ/DYo7Efq4/n3jo hkhA35II3gXiH2eqvUry3lPG2c8a0aZ79vS38UpgD2bAgAa2DUO15Aeqd7r3UDZ3cyojrW z9Q5Jp4f99aa9EPhJzZTvvU7GD7cXRE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-KYswmiGyN16XpYPWkvwFQQ-1; Tue, 20 Apr 2021 05:25:24 -0400 X-MC-Unique: KYswmiGyN16XpYPWkvwFQQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53EF887A826; Tue, 20 Apr 2021 09:25:23 +0000 (UTC) Received: from work-vm (ovpn-112-16.ams2.redhat.com [10.36.112.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5FCC39A73; Tue, 20 Apr 2021 09:25:15 +0000 (UTC) Date: Tue, 20 Apr 2021 10:25:12 +0100 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [PATCH] migration: Deprecate redundant query-migrate result @blocked Message-ID: References: <20210420051907.891470-1-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Markus Armbruster , peterx@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Daniel P. Berrangé (berrange@redhat.com) wrote: > On Tue, Apr 20, 2021 at 07:19:06AM +0200, Markus Armbruster wrote: > > Result @blocked is true when and only when result @blocked-reasons is > > present. It's always non-empty when present. @blocked is redundant. > > It was introduced in commit 3af8554bd0 "migration: Add blocker > > information", and has not been released. This gives us a chance to > > fix the interface with minimal fuss. > > > > Unfortunately, we're already too close to the release to risk dropping > > it. Deprecate it instead. > > > > Signed-off-by: Markus Armbruster > > --- > > This is alternative to "[PATCH v2] migration: Drop redundant > > query-migrate result @blocked". > > > > qapi/migration.json | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > Reviewed-by: Daniel P. Berrangé Yes, Reviewed-by: Dr. David Alan Gilbert Peter: Do you want to pick that up directly ? Dave > > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK