From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A0C9C433ED for ; Fri, 9 Apr 2021 09:12:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E838B610D0 for ; Fri, 9 Apr 2021 09:12:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E838B610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUnC7-0006PR-T4 for qemu-devel@archiver.kernel.org; Fri, 09 Apr 2021 05:12:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUn9v-00046n-1N for qemu-devel@nongnu.org; Fri, 09 Apr 2021 05:10:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUn9n-0002mw-BS for qemu-devel@nongnu.org; Fri, 09 Apr 2021 05:10:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617959426; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NtfvK9Wh/UYUrzTJjO5FGGnknAjv1q1/gE+jZkBdJ2A=; b=CQD289m8PcJScly0mSQRj3c4HyT6WP26KZl7OdcByfw/1EUtz9q8H89mmjiyY6aPZpzipi yap4uSINY8FeEAQBqXBmEYJuVe9WVdmaJ4gtWE3+/kymrSQZ+RMyp/c4L9joK2u6JHzGYG F7bV5SzMuaQ47ROw4zsL+ixzVCvzwEc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-zYEiyl4LNpen2DjuPFKMbQ-1; Fri, 09 Apr 2021 05:10:24 -0400 X-MC-Unique: zYEiyl4LNpen2DjuPFKMbQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5376D10054F6 for ; Fri, 9 Apr 2021 09:10:23 +0000 (UTC) Received: from redhat.com (ovpn-115-36.ams2.redhat.com [10.36.115.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FB7D5D9E3; Fri, 9 Apr 2021 09:10:21 +0000 (UTC) Date: Fri, 9 Apr 2021 10:10:18 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Dr. David Alan Gilbert (git)" Subject: Re: [RFC PATCH 4/5] migration/socket: Close the listener at the end Message-ID: References: <20210408191159.133644-1-dgilbert@redhat.com> <20210408191159.133644-5-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210408191159.133644-5-dgilbert@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: quintela@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, pabeni@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Apr 08, 2021 at 08:11:58PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Delay closing the listener until the cleanup hook at the end; mptcp > needs the listener to stay open while the other paths come in. So you're saying that when the 'accept(2)' call returns, we are only guaranteed to have 1 single path accepted, and the other paths will be accepted by the kernel asynchronously ? Hence we need to keep listening, even though we're not going to call accept(2) again ourselves ? > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/multifd.c | 5 +++++ > migration/socket.c | 24 ++++++++++++++++++------ > 2 files changed, 23 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|