From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24B5C433B4 for ; Wed, 14 Apr 2021 18:51:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 117BE600D1 for ; Wed, 14 Apr 2021 18:51:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 117BE600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWkbs-00078M-3W for qemu-devel@archiver.kernel.org; Wed, 14 Apr 2021 14:51:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWkZs-0006QW-Rx for qemu-devel@nongnu.org; Wed, 14 Apr 2021 14:49:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWkZn-0003Ez-RJ for qemu-devel@nongnu.org; Wed, 14 Apr 2021 14:49:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618426161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdpPzbVadwD3U+K13PrC6uHUekGfs8vSZx3AuRlTs7Y=; b=eH+7fki+QMrb1j1Z5suDeMpJ4p7J8VjRRHmViGzoyHAL8AS+S/KN7PU9spRZcyh26lhW1t /CEnRla+9y054ZfwU8r9w5oo6BlePDoxMrGiMyrBkMIg8ttAOm/qNGzrDuE79PBNaJU2QW 8Jtuvbpspap5tbxFtk6x2hegcZfwA/A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-FHZ6GX6eOgC9YSzeCj7iTQ-1; Wed, 14 Apr 2021 14:49:16 -0400 X-MC-Unique: FHZ6GX6eOgC9YSzeCj7iTQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B235ABBF04 for ; Wed, 14 Apr 2021 18:49:15 +0000 (UTC) Received: from work-vm (ovpn-115-158.ams2.redhat.com [10.36.115.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0653F5D6A8; Wed, 14 Apr 2021 18:49:13 +0000 (UTC) Date: Wed, 14 Apr 2021 19:49:11 +0100 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [RFC PATCH 0/5] mptcp support Message-ID: References: <20210408191159.133644-1-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, pabeni@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Daniel P. Berrangé (berrange@redhat.com) wrote: > On Mon, Apr 12, 2021 at 03:51:10PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berrange@redhat.com) wrote: > > > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git) wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > > > Hi, > > > > This RFC set adds support for multipath TCP (mptcp), > > > > in particular on the migration path - but should be extensible > > > > to other users. > > > > > > > > Multipath-tcp is a bit like bonding, but at L3; you can use > > > > it to handle failure, but can also use it to split traffic across > > > > multiple interfaces. > > > > > > > > Using a pair of 10Gb interfaces, I've managed to get 19Gbps > > > > (with the only tuning being using huge pages and turning the MTU up). > > > > > > > > It needs a bleeding-edge Linux kernel (in some older ones you get > > > > false accept messages for the subflows), and a C lib that has the > > > > constants defined (as current glibc does). > > > > > > > > To use it you just need to append ,mptcp to an address; > > > > > > > > -incoming tcp:0:4444,mptcp > > > > migrate -d tcp:192.168.11.20:4444,mptcp > > > > > > What happens if you only enable mptcp flag on one side of the > > > stream (whether client or server), does it degrade to boring > > > old single path TCP, or does it result in an error ? > > > > I've just tested this and it matches what pabeni said; it seems to just > > fall back. > > > > > > I had a quick go at trying NBD as well, but I think it needs > > > > some work with the parsing of NBD addresses. > > > > > > In theory this is applicable to anywhere that we use sockets. > > > Anywhere that is configured with the QAPI SocketAddress / > > > SocketAddressLegacy type will get it for free AFAICT. > > > > That was my hope. > > > > > Anywhere that is configured via QemuOpts will need an enhancement. > > > > > > IOW, I would think NBD already works if you configure NBD via > > > QMP with nbd-server-start, or block-export-add. qemu-nbd will > > > need cli options added. > > > > > > The block layer clients for NBD, Gluster, Sheepdog and SSH also > > > all get it for free when configured va QMP, or -blockdev AFAICT > > > > Have you got some examples via QMP? > > I'd failed trying -drive if=virtio,file=nbd://192.168.11.20:3333,mptcp=on/zero > > I never remember the mapping to blockdev QAPI schema, especially > when using legacy filename syntax with the URI. > > Try instead > > -blockdev driver=nbd,host=192.168.11.20,port=3333,mptcp=on,id=disk0backend > -device virtio-blk,drive=disk0backend,id=disk0 That doesn't look like the right syntax, but it got me closer; and it's working with no more code changes: On the source: qemu... -nographic -M none -drive if=none,file=my.qcow2,id=mydisk (qemu) nbd_server_start 0.0.0.0:3333,mptcp=on (qemu) nbd_server_add -w mydisk On the destination: -blockdev driver=nbd,server.type=inet,server.host=192.168.11.20,server.port=3333,server.mptcp=on,node-name=nbddisk,export=mydisk -device virtio-blk,drive=nbddisk,id=disk0 and it succesfully booted off it, and it looks like it has two flows. (It didn't get that great a bandwidth, but I'm not sure where that's due to). Dave > > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK