From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1EB5C433B4 for ; Thu, 15 Apr 2021 17:29:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B9A861074 for ; Thu, 15 Apr 2021 17:29:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B9A861074 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX5oE-0006fK-5j for qemu-devel@archiver.kernel.org; Thu, 15 Apr 2021 13:29:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX5e0-0005Gu-Nt; Thu, 15 Apr 2021 13:19:09 -0400 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:39401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX5dw-0007kD-4C; Thu, 15 Apr 2021 13:19:08 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 951BA1A16; Thu, 15 Apr 2021 13:18:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 15 Apr 2021 13:18:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=DohkFW+Icdqd+ECH30OxCQLgaQ8 kQQyakpR/Mq4hyoI=; b=2dTiXtsTDtC1+upp1VHuxwZV6gZyCa9rb2pSi7IFSQ/ 5UkA9GEI3EnanxT81lpfrZiAvFfTs1Q0zyGOPRAuyVKbyLy05vTudpEfARtL5P/F zE99aSUsBekTEb9fyeC35jqSTJ7vIe8NJ+JvkqT6T3Ag+NSG7WAJDz+L7fJcNItQ 0wR2sw8ybxJQKeIYUNoPTqHA6zIzHfeaFLSVDBF7Z0DcRhbbSQWx5v0BkhwKYuxn n9Hw03pi+xOR35XQFloKdR5APqM9666siEePwNcRzd3oddjPLfz04AJWtxRFA7eT XliAlOPtHF7soUIYe2BmLGLqzpJ+FFTdL+ygLisNtGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=DohkFW +Icdqd+ECH30OxCQLgaQ8kQQyakpR/Mq4hyoI=; b=vPqbLZ6DrcIt+krn5c1Atk 6wVZbczburqgnS3QNEhZf9MzYpFWmaWvnixqCc7jDF7vwpxpiCBHCZBYgqJKAfNB YUKGQCG/UUZnYo3EXQhYQvUJZqCrJQsjnejeSEMaT6P7eHPY+hlW0QyJk+xslCdC Wb29TK4CUSBl5iQCW8N8Ivpyd6Cf7TdcJgJ4+dw2I2T0UdacwfUtJMhAwoTGPya+ D402/AEkChYL76DlwsRImaT5oSvhuF88ERpu4nClsp8j3t7koNMztfjmDeMd2UOH 25ZyOQCQ+fRqPPMNYOnfQ+B7ymVW/7iJlvFejAQvLdcSVtTu8jDSvtTQybN/5d+Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelfedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvddu ffeknecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 63A9624005B; Thu, 15 Apr 2021 13:18:53 -0400 (EDT) Date: Thu, 15 Apr 2021 19:18:50 +0200 From: Klaus Jensen To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2] hw/block/nvme: align with existing style Message-ID: References: <20210415120048.5484-1-anaidu.gollu@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="btMPu+fDapW2aDgm" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.26; envelope-from=its@irrelevant.dk; helo=wnew1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org, Gollu Appalanaidu , qemu-devel@nongnu.org, Markus Armbruster , stefanha@redhat.com, kbusch@kernel.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --btMPu+fDapW2aDgm Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Apr 15 15:13, Philippe Mathieu-Daud=C3=A9 wrote: >On 4/15/21 2:00 PM, Gollu Appalanaidu wrote: >> Make uniform hexadecimal numbers format. >> >> Signed-off-by: Gollu Appalanaidu >> --- >> -v2: Address review comments (Klaus) >> use lower case hexa format for the code and in comments >> use the same format as used in Spec. ("FFFFFFFFh") > >^ This comment is relevant to the commit message. > >Also it would be nice if the subsystem could describe somewhere >what is its style. Not sure where... The file header is probably >the simplest place. > >Something like: > >"While QEMU coding style prefers lowercase hexadecimal in constants, >the NVMe subsystem use the format from the NVMe specifications in >the comments: no '0x' prefix, uppercase, 'h' hexadecimal suffix." > +1 for that suggestion. >> hw/block/nvme-ns.c | 2 +- >> hw/block/nvme.c | 40 ++++++++++++++++++++-------------------- >> include/block/nvme.h | 10 +++++----- >> 3 files changed, 26 insertions(+), 26 deletions(-) > > --btMPu+fDapW2aDgm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmB4dXkACgkQTeGvMW1P DemePAf/WHWTJOcPTpEr/9lhfy7kYSYlsMV8NE7XIBbK4OGkNnfJUTiyHRkNkX6W CJ7bpbu8/LK8GmQ3oSHO6BGRuQMXmKy1C2jL73zPx/N6gkBHqgpvvIkhmH0uBO6i mAB6sCGDF2O7A/wGGdDvI0eMYZJ3BCNvAVSFPx22sAM/aG4o9KNz71Z9cjd/NHMI wAp3m7rPz9yccZuXljQ+EcaLjxZiuDkJbnzWVQoGo5U2UOu5VO/B9szdfCpR8SGb qyGUBpEuV6HUGKmwewNdGap6cg1rPKJUnr9UyZ43K/XeVgJIrcLR7KdtGKCZhvwt Ra8GMPgnEVCYL2wCokUq23Do97gAfw== =KSG/ -----END PGP SIGNATURE----- --btMPu+fDapW2aDgm--