From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FD2C433ED for ; Mon, 26 Apr 2021 12:20:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75AA56135A for ; Mon, 26 Apr 2021 12:20:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75AA56135A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb0EN-0000iY-4J for qemu-devel@archiver.kernel.org; Mon, 26 Apr 2021 08:20:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb0Cr-0000CO-JQ for qemu-devel@nongnu.org; Mon, 26 Apr 2021 08:19:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb0Cp-00089x-Qg for qemu-devel@nongnu.org; Mon, 26 Apr 2021 08:19:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619439555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5Fj64BEJ3qvAnLT+NXgGebuCM85YYA0vCjmI5tpe5Hk=; b=YmFoX5KKaxT8urApKBsZW1sRtPKsDeysFfUkxvsl700u7g9doyf1A35WFm4KcIKIGHBqPV MxiAmftTSEUV0hc0dE1Ib7Zpi+eHXRSDs/mdKeqW12WjuOIMHGjjCviFOMQQmOSVa/a6sn 6kbAD7h0rxEdHHTDh35VE39TX0uFOtw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-F-zUrG_mOBeWpJsuAPHIvw-1; Mon, 26 Apr 2021 08:19:13 -0400 X-MC-Unique: F-zUrG_mOBeWpJsuAPHIvw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 038081008068; Mon, 26 Apr 2021 12:19:12 +0000 (UTC) Received: from work-vm (ovpn-115-8.ams2.redhat.com [10.36.115.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 030921002388; Mon, 26 Apr 2021 12:19:07 +0000 (UTC) Date: Mon, 26 Apr 2021 13:19:05 +0100 From: "Dr. David Alan Gilbert" To: Edge NFV , alex.williamson@redhat.com Subject: Re: [PATCH] make vfio and DAX cache work together Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.219, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Edge NFV (edgenfv@gmail.com) wrote: > Signed-off-by: Edge NFV Hi, I take it that 'Edge NFV' isn't your real name; apologies if it is. It's unusual not to use a real name; I would be interested to know why you feel uncomfortable not doing. > --- > hw/vfio/common.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > index ae5654fcdb..83e15bf7a3 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/common.c > @@ -668,6 +668,15 @@ static void vfio_listener_region_add(MemoryListener > *listener, > int128_get64(int128_sub(section->size, int128_one()))); > return; > } > + > + /* Do not add virtio fs cache section */ > + if (!strcmp(memory_region_name(section->mr), "virtio-fs-cache")) { So first, this is a patch that fixes something that isn't yet in qemu; the DAX mode of virtiofs. Secondly, hard coding the name like this is probably the wrong thing to do; we need a way for the cache to declare it wants to be omitted. Thirdly, shouldn't this actually be a change to vfio_listener_skip_section to add this test? Dave > + trace_vfio_listener_region_add_skip( > + section->offset_within_address_space, > + section->offset_within_address_space + > + int128_get64(int128_sub(section->size, int128_one()))); > + return; > + } > > if (unlikely((section->offset_within_address_space & > ~qemu_real_host_page_mask) != > -- > 2.25.1 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK