From: Peter Krempa <pkrempa@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Christoph Hellwig <hch@lst.de>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property
Date: Fri, 30 Apr 2021 09:58:12 +0200 [thread overview]
Message-ID: <YIu4lDTeg1TZKWZg@angien.pipo.sk> (raw)
In-Reply-To: <87lf905icy.fsf@dusky.pond.sub.org>
On Fri, Apr 30, 2021 at 09:42:05 +0200, Markus Armbruster wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
> > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote:
> >> The scsi=on|off property was deprecated in QEMU 5.0 and can be removed
> >> completely at this point.
> >>
> >> Drop the scsi=on|off option. It was only available on Legacy virtio-blk
> >> devices. Linux v5.6 already dropped support for it.
> >>
> >> Remove the hw_compat_2_4[] property assignment since scsi=on|off no
> >> longer exists. Old guests with Legacy virtio-blk devices no longer see
> >> the SCSI host features bit.
> >>
> >
> > This means pc-2.4 will now break guest ABI if using virtio-blk
> > devices, correct?
> >
> > This looks like a sign we should have deprecated pc-2.4 a long
> > time ago.
>
> The last batch of PC machine type retiring was pc-1.0 to pc-1.3:
> deprecated in 5.0 (commit 30d2a17b4, Dec 2019), dropped in 6.0 (commit
> f862ddbb1, just weeks ago). pc-1.3 was a bit over seven years old when
> we released 5.0. pc-2.4 will be six years old by the time we release
> 6.1. Fair game?
As a data-point, libvirt will be dropping support for <qemu-2.10
(release, not the machine type) in the upcomming release. I'm not sure
whether that justifies more deprecation though.
next prev parent reply other threads:[~2021-04-30 7:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 15:52 [PATCH] virtio-blk: drop deprecated scsi=on|off property Stefan Hajnoczi
2021-04-29 16:16 ` Peter Krempa
2021-05-04 14:31 ` Stefan Hajnoczi
2021-04-29 18:03 ` Eduardo Habkost
2021-04-30 7:42 ` Markus Armbruster
2021-04-30 7:58 ` Peter Krempa [this message]
2021-05-04 10:45 ` Dr. David Alan Gilbert
2021-05-04 14:28 ` Stefan Hajnoczi
2021-05-04 14:32 ` Stefan Hajnoczi
2021-05-04 15:26 ` Eduardo Habkost
2021-04-30 5:47 ` Michal Prívozník
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIu4lDTeg1TZKWZg@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).