From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: raphael.norwitz@nutanix.com, qemu-devel@nongnu.org,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [PATCH v2] vhost-user-blk: Fail gracefully on too large queue size
Date: Fri, 30 Apr 2021 11:17:28 +0200 [thread overview]
Message-ID: <YIvLKGjwF9XPjAAp@merkur.fritz.box> (raw)
In-Reply-To: <20210413165654.50810-1-kwolf@redhat.com>
Am 13.04.2021 um 18:56 hat Kevin Wolf geschrieben:
> virtio_add_queue() aborts when queue_size > VIRTQUEUE_MAX_SIZE, so
> vhost_user_blk_device_realize() should check this before calling it.
>
> Simple reproducer:
>
> qemu-system-x86_64 \
> -chardev null,id=foo \
> -device vhost-user-blk-pci,queue-size=4096,chardev=foo
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1935014
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Thanks for the review, applied to the block branch.
Kevin
prev parent reply other threads:[~2021-04-30 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 16:56 [PATCH v2] vhost-user-blk: Fail gracefully on too large queue size Kevin Wolf
2021-04-13 17:08 ` Philippe Mathieu-Daudé
2021-04-13 18:23 ` Raphael Norwitz
2021-04-14 10:37 ` Stefan Hajnoczi
2021-04-30 9:17 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIvLKGjwF9XPjAAp@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).