From: Stefan Hajnoczi <stefanha@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [for-6.1 3/4] virtio-scsi: Set host notifiers and callbacks separately
Date: Wed, 5 May 2021 11:16:54 +0100 [thread overview]
Message-ID: <YJJwlmmtj2SslG9z@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210407143501.244343-4-groug@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Wed, Apr 07, 2021 at 04:35:00PM +0200, Greg Kurz wrote:
> Host notifiers are guaranteed to be idle until the callbacks are
> hooked up with virtio_queue_aio_set_host_notifier_handler(). They
> thus don't need to be set or unset with the AioContext lock held.
>
> Do this outside the critical section, like virtio-blk already
> does : basically downgrading virtio_scsi_vring_init() to only
> setup the host notifier and set the callback in the caller.
>
> This will allow to batch addition/deletion of ioeventds in
> a single memory transaction, which is expected to greatly
> improve initialization time.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> hw/scsi/virtio-scsi-dataplane.c | 40 ++++++++++++++++++---------------
> 1 file changed, 22 insertions(+), 18 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-05 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 14:34 [for-6.1 0/4] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci Greg Kurz
2021-04-07 14:34 ` [for-6.1 1/4] virtio-blk: Fix rollback path in virtio_blk_data_plane_start() Greg Kurz
2021-04-07 14:34 ` [for-6.1 2/4] virtio-blk: Configure all host notifiers in a single MR transaction Greg Kurz
2021-05-05 10:14 ` Stefan Hajnoczi
2021-05-05 11:15 ` Greg Kurz
2021-05-06 8:15 ` Michael S. Tsirkin
2021-04-07 14:35 ` [for-6.1 3/4] virtio-scsi: Set host notifiers and callbacks separately Greg Kurz
2021-05-05 10:16 ` Stefan Hajnoczi [this message]
2021-04-07 14:35 ` [for-6.1 4/4] virtio-scsi: Configure all host notifiers in a single MR transaction Greg Kurz
2021-05-05 10:17 ` Stefan Hajnoczi
2021-04-19 15:31 ` [for-6.1 0/4] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci Greg Kurz
2021-04-19 21:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJJwlmmtj2SslG9z@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).