From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7353C433B4 for ; Tue, 11 May 2021 09:31:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6977C613C0 for ; Tue, 11 May 2021 09:31:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6977C613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgOjb-0001dj-AO for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 05:31:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgOW5-00041I-TU for qemu-devel@nongnu.org; Tue, 11 May 2021 05:17:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgOVy-0002g7-TT for qemu-devel@nongnu.org; Tue, 11 May 2021 05:17:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620724637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vpiMnPLYSVWHN3mXou1FFiyljf3PCOASSkAV98n2gzM=; b=BFTNqrJXjFvi/3hjAWs8X4RJaNTLbjUW2susi35Ke5IiOMySHM8CZSjGNDqqAJkCZvLhAc sO+MDc70DQTQDVUJ0xrD3Il8SNgXUHVWq1FOwh9N0wlIP+a2HYFNHJzqvGCrheMsLv+OVX AywfR9BuqWUbfHFJT1x9CGlMiDDE548= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-QaUJe9vGOzKBnjQlPNk_Zw-1; Tue, 11 May 2021 05:17:15 -0400 X-MC-Unique: QaUJe9vGOzKBnjQlPNk_Zw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33000107ACE3; Tue, 11 May 2021 09:17:14 +0000 (UTC) Received: from work-vm (ovpn-113-51.ams2.redhat.com [10.36.113.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A63C96267D; Tue, 11 May 2021 09:17:09 +0000 (UTC) Date: Tue, 11 May 2021 10:17:07 +0100 From: "Dr. David Alan Gilbert" To: Kunkun Jiang Subject: Re: [PATCH v4 0/2] Some modification about ram_save_host_page() Message-ID: References: <20210316125716.1243-1-jiangkunkun@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210316125716.1243-1-jiangkunkun@huawei.com> User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , David Edmondson , "open list:All patches CC here" , Peter Xu , =?iso-8859-1?Q?C=E9dric?= Le Goater , Alexey Romko , Zenghui Yu , wanghaibin.wang@huawei.com, Keqian Zhu , Andrey Gruzdev Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Kunkun Jiang (jiangkunkun@huawei.com) wrote: > Hi all, Queued; sorry for the delay > This series include patches as below: > Patch 1: > - reduce unnecessary rate limiting in ram_save_host_page() > > Patch 2: > - optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find > dirty pages > > History: > > v3 -> v4: > - Remove the modification to ram_save_host_page() comment [Peter Xu] > - Remove the renaming of tmppages > > v2 -> v3: > - Reduce unnecessary rate limiting if nothing is sent in the current iteration [David Edmondson] > - Invert the body of the loop in ram_save_host_page() [David Edmondson] > > v1 -> v2: > - Modify ram_save_host_page() comment [David Edmondson] > - Remove 'goto' [David Edmondson] > > Kunkun Jiang (2): > migration/ram: Reduce unnecessary rate limiting > migration/ram: Optimize ram_save_host_page() > > migration/ram.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > -- > 2.23.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK