From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Stefan Weil" <sw@weilnetz.de>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2
Date: Tue, 11 May 2021 15:32:21 +0100 [thread overview]
Message-ID: <YJqVdeGVsiMh1N6r@redhat.com> (raw)
In-Reply-To: <97e4071e-3d62-40f1-7d08-6718f2f7153a@redhat.com>
On Tue, May 11, 2021 at 04:18:54PM +0200, Thomas Huth wrote:
> On 11/05/2021 15.26, Daniel P. Berrangé wrote:
> > Several distros have been dropped since the last time we bumped the
> > minimum required CLang version.
> [...]
> > -# if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4)
> > -# error You need at least Clang v3.4 to compile QEMU
> > +# if __clang_major__ < 7 || (__clang_major__ == 7 && __clang_minor__ < 0)
>
> __clang_minor__ < 0 is very unlikely ... I think you could drop the part
> after the "||".
True, though it might be desirable to keep it as a placeholder for when
we next bump the min version and have a non-zero minor digit.
>
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-05-11 14:37 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 13:26 [PATCH 00/12] Wave goodbye to RHEL 7 vintage distros Daniel P. Berrangé
2021-05-11 13:26 ` [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8 Daniel P. Berrangé
2021-05-11 13:54 ` Thomas Huth
2021-05-11 14:04 ` Daniel P. Berrangé
2021-05-12 16:19 ` Philippe Mathieu-Daudé
2021-05-12 16:28 ` Peter Maydell
2021-05-11 13:26 ` [PATCH 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container Daniel P. Berrangé
2021-05-11 13:57 ` Thomas Huth
2021-05-11 13:26 ` [PATCH 03/12] crypto: bump min nettle to 3.3, dropping RHEL-7 support Daniel P. Berrangé
2021-05-11 14:01 ` Thomas Huth
2021-05-11 20:56 ` Willian Rampazzo
2021-05-12 0:40 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 04/12] crypto: drop back compatibility typedefs for nettle Daniel P. Berrangé
2021-05-11 14:03 ` Thomas Huth
2021-05-12 0:40 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 05/12] crypto: bump min gcrypt to 1.7.6, dropping RHEL-7 support Daniel P. Berrangé
2021-05-11 14:06 ` Thomas Huth
2021-05-11 20:58 ` Willian Rampazzo
2021-05-12 0:40 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 06/12] crypto: bump min gnutls to 3.5.8, " Daniel P. Berrangé
2021-05-11 14:07 ` Thomas Huth
2021-05-11 20:59 ` Willian Rampazzo
2021-05-12 0:39 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 07/12] crypto: drop used conditional check Daniel P. Berrangé
2021-05-11 21:01 ` Willian Rampazzo
2021-05-12 0:41 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 08/12] tests/vm: convert centos VM recipe to CentOS 8 Daniel P. Berrangé
2021-05-11 15:04 ` Daniel P. Berrangé
2021-05-11 13:26 ` [PATCH 09/12] tests/docker: drop CentOS 7 container Daniel P. Berrangé
2021-05-11 14:09 ` Thomas Huth
2021-05-11 14:25 ` Alex Bennée
2021-05-11 20:52 ` Willian Rampazzo
2021-05-11 13:26 ` [PATCH 10/12] bump min required glib version to 2.50 Daniel P. Berrangé
2021-05-11 14:11 ` Thomas Huth
2021-05-11 21:03 ` Willian Rampazzo
2021-05-11 13:26 ` [PATCH 11/12] configure: bump min required GCC to 6.3.0 Daniel P. Berrangé
2021-05-11 14:15 ` Thomas Huth
2021-05-11 14:31 ` Daniel P. Berrangé
2021-05-11 21:04 ` Willian Rampazzo
2021-05-12 0:43 ` Richard Henderson
2021-05-11 13:26 ` [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2 Daniel P. Berrangé
2021-05-11 14:18 ` Thomas Huth
2021-05-11 14:32 ` Daniel P. Berrangé [this message]
2021-05-11 21:05 ` Willian Rampazzo
2021-05-12 0:44 ` Richard Henderson
2021-05-12 11:44 ` Philippe Mathieu-Daudé
2021-05-12 11:53 ` non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2) Thomas Huth
2021-05-12 13:47 ` Willian Rampazzo
2021-05-12 13:55 ` Thomas Huth
2021-05-12 13:59 ` Willian Rampazzo
2021-05-12 14:33 ` Thomas Huth
2021-05-12 14:00 ` Daniel P. Berrangé
2021-05-12 14:51 ` Philippe Mathieu-Daudé
2021-05-12 15:29 ` Daniel P. Berrangé
2021-05-12 12:25 ` [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2 Daniel P. Berrangé
2021-05-12 14:10 ` Philippe Mathieu-Daudé
2021-05-12 14:43 ` Daniel P. Berrangé
2021-05-11 14:33 ` [PATCH 00/12] Wave goodbye to RHEL 7 vintage distros Thomas Huth
2021-05-13 10:05 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJqVdeGVsiMh1N6r@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).