From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AD2C47088 for ; Wed, 26 May 2021 15:31:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A44AD613C9 for ; Wed, 26 May 2021 15:31:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A44AD613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llvUy-0004Vx-SD for qemu-devel@archiver.kernel.org; Wed, 26 May 2021 11:31:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llvTm-0003ZS-Uz for qemu-devel@nongnu.org; Wed, 26 May 2021 11:29:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llvTj-0000oR-Ca for qemu-devel@nongnu.org; Wed, 26 May 2021 11:29:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622042990; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KYPJuDXgmWfOmR7/Vbr1wRgk8rTC7p6YuF28NKlx0VA=; b=aM6X+lwdZh9EWIlkRLxcUdyWhjXGqr7R+wwkFCJujIm+CAp26//0ymh79jH54AnRUZoWSF x+Yx3T88mO2vciooeHagjtR53HpbDSxvgUJspgIl1T/MiN7rMRrKJZZIB5Sdp6G6b8EcXT 4LoYvojyf0y2z1KH9GKDmqPtv6I8+4A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-tDARyUWLOR-T0QPtxiU66Q-1; Wed, 26 May 2021 11:29:42 -0400 X-MC-Unique: tDARyUWLOR-T0QPtxiU66Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52A11107ACCD; Wed, 26 May 2021 15:29:41 +0000 (UTC) Received: from redhat.com (ovpn-115-19.ams2.redhat.com [10.36.115.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6DEC6787A; Wed, 26 May 2021 15:29:39 +0000 (UTC) Date: Wed, 26 May 2021 16:29:36 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Doug Evans Subject: Re: RFC: IPv6 hostfwd command line syntax [was Re: [PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse] Message-ID: References: <20210415033925.1290401-1-dje@google.com> <20210415033925.1290401-3-dje@google.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Samuel Thibault , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 26, 2021 at 08:26:33AM -0700, Doug Evans wrote: > On Wed, May 26, 2021 at 6:57 AM Daniel P. Berrangé > wrote: > > > On Tue, May 25, 2021 at 12:37:21PM -0700, Doug Evans wrote: > > > Hi. > > > > > > I want to confirm the command line syntax y'all want for ipv6 host > > > forwarding. > > > > > > IIUC, the command line syntax is required to be consistent with the use > > of > > > "ipv6=on|off" elsewhere. > > > Can you confirm that's correct? > > > > > > If so, how does one apply "ipv6=on" to the "::60022-:22" hostfwd spec in > > > the following example: > > > > > > $ qemu-system-x86_64 [...] --nic > > user,id=n1,model=e1000,hostfwd=::60022-:22 > > > > > > ? > > > > Probably easier if we start from the HMP hostfwd_add command which takes > > > > hostfwd_add ::60022-:22 > > > > With that, adding the flags is obvious > > > > hostfwd_add ::60022-:22,ipv6=on|off,ipv4=on|off > > > > > Data point: > > There's been discussion of supporting ipv6->ipv4 and ipv4->ipv6. > If we want to provide for this then the ipv4/6 flags need to apply to the > host/guess address. > > E.g., > > hostfwd_add ::60022,ipv6=on-:22,ipv4=on > [for ipv6->ipv4] Yes, good point, that would make sense. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|