From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Laurent Vivier <laurent@vivier.eu>, Max Reitz <mreitz@redhat.com>,
virtio-fs@redhat.com, Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Brad Smith <brad@comstyle.com>
Subject: Re: [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages
Date: Fri, 11 Jun 2021 17:28:35 +0100 [thread overview]
Message-ID: <YMOPM87ZdWWQOUsR@redhat.com> (raw)
In-Reply-To: <20210505103702.521457-4-berrange@redhat.com>
ping: anyone willing to give a review of this one
On Wed, May 05, 2021 at 11:36:58AM +0100, Daniel P. Berrangé wrote:
> The GDateTime APIs provided by GLib avoid portability pitfalls, such
> as some platforms where 'struct timeval.tv_sec' field is still 'long'
> instead of 'time_t'. When combined with automatic cleanup, GDateTime
> often results in simpler code too.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> hw/net/rocker/rocker.h | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
> index 941c932265..412fa44d01 100644
> --- a/hw/net/rocker/rocker.h
> +++ b/hw/net/rocker/rocker.h
> @@ -25,14 +25,9 @@
> #if defined(DEBUG_ROCKER)
> # define DPRINTF(fmt, ...) \
> do { \
> - struct timeval tv; \
> - char timestr[64]; \
> - time_t now; \
> - gettimeofday(&tv, NULL); \
> - now = tv.tv_sec; \
> - strftime(timestr, sizeof(timestr), "%T", localtime(&now)); \
> - fprintf(stderr, "%s.%06ld ", timestr, tv.tv_usec); \
> - fprintf(stderr, "ROCKER: " fmt, ## __VA_ARGS__); \
> + g_autoptr(GDateTime) now = g_date_time_new_now_local(); \
> + g_autofree char *nowstr = g_date_time_format(now, "%T.%f");\
> + fprintf(stderr, "%s ROCKER: " fmt, nowstr, ## __VA_ARGS__);\
> } while (0)
> #else
> static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
> --
> 2.31.1
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-06-11 16:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 10:36 [PATCH 0/7] replace all use of strftime() with g_date_time_format() Daniel P. Berrangé
2021-05-05 10:36 ` [PATCH 1/7] migration: use GDateTime for formatting timestamp in snapshot names Daniel P. Berrangé
2021-05-05 14:42 ` Dr. David Alan Gilbert
2021-05-06 3:14 ` Brad Smith
2021-05-05 10:36 ` [PATCH 2/7] block: use GDateTime for formatting timestamp when dumping snapshot info Daniel P. Berrangé
2021-05-07 17:05 ` Max Reitz
2021-05-05 10:36 ` [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages Daniel P. Berrangé
2021-06-11 16:28 ` Daniel P. Berrangé [this message]
2021-06-14 16:43 ` Juan Quintela
2021-05-05 10:36 ` [PATCH 4/7] usb/dev-mtp: use GDateTime for formatting timestamp for objects Daniel P. Berrangé
2021-05-05 13:08 ` Gerd Hoffmann
2021-05-05 10:37 ` [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers Daniel P. Berrangé
2021-06-11 16:29 ` Daniel P. Berrangé
2021-06-14 15:41 ` Dr. David Alan Gilbert
2021-05-05 10:37 ` [PATCH 6/7] linux-user: use GDateTime for formatting timestamp for core file Daniel P. Berrangé
2021-05-05 11:18 ` Laurent Vivier
2021-05-15 19:51 ` Laurent Vivier
2021-05-05 10:37 ` [PATCH 7/7] virtiofsd: use GDateTime for formatting timestamp for debug messages Daniel P. Berrangé
2021-05-05 14:51 ` Dr. David Alan Gilbert
2021-05-06 16:00 ` Dr. David Alan Gilbert
2021-05-06 17:45 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMOPM87ZdWWQOUsR@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=brad@comstyle.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).