From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH] migration/rdma: Use error_report to suppress errno message
Date: Thu, 1 Jul 2021 10:31:35 +0100 [thread overview]
Message-ID: <YN2Ld+HvZJCd51h1@work-vm> (raw)
In-Reply-To: <20210628071959.23455-1-lizhijian@cn.fujitsu.com>
* Li Zhijian (lizhijian@cn.fujitsu.com) wrote:
> Since the prior calls are successful, in this case a errno doesn't
> indicate a real error which would just make us confused.
>
> before:
> (qemu) migrate -d rdma:192.168.22.23:8888
> source_resolve_host RDMA Device opened: kernel name rxe_eth0 uverbs device name uverbs2, infiniband_verbs class device path /sys/class/infiniband_verbs/uverbs2, infiniband class device path /sys/class/infiniband/rxe_eth0, transport: (2) Ethernet
> rdma_get_cm_event != EVENT_ESTABLISHED after rdma_connect: No space left on device
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
and queued
> ---
> migration/rdma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index d90b29a4b51..b6cc4bef4a8 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -1006,7 +1006,7 @@ route:
> if (cm_event->event != RDMA_CM_EVENT_ADDR_RESOLVED) {
> ERROR(errp, "result not equal to event_addr_resolved %s",
> rdma_event_str(cm_event->event));
> - perror("rdma_resolve_addr");
> + error_report("rdma_resolve_addr");
> rdma_ack_cm_event(cm_event);
> ret = -EINVAL;
> goto err_resolve_get_addr;
> @@ -2544,7 +2544,7 @@ static int qemu_rdma_connect(RDMAContext *rdma, Error **errp, bool return_path)
> }
>
> if (cm_event->event != RDMA_CM_EVENT_ESTABLISHED) {
> - perror("rdma_get_cm_event != EVENT_ESTABLISHED after rdma_connect");
> + error_report("rdma_get_cm_event != EVENT_ESTABLISHED after rdma_connect");
> ERROR(errp, "connecting to destination!");
> rdma_ack_cm_event(cm_event);
> goto err_rdma_source_connect;
> --
> 2.31.1
>
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2021-07-01 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 7:19 [PATCH] migration/rdma: Use error_report to suppress errno message Li Zhijian
2021-07-01 9:31 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN2Ld+HvZJCd51h1@work-vm \
--to=dgilbert@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).