From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1016CC07E95 for ; Tue, 20 Jul 2021 14:48:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 896F761358 for ; Tue, 20 Jul 2021 14:48:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 896F761358 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5r31-0000DB-Cm for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 10:48:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5qzm-0007ix-HI for qemu-devel@nongnu.org; Tue, 20 Jul 2021 10:45:18 -0400 Received: from ozlabs.org ([203.11.71.1]:50515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5qzj-00088f-BZ for qemu-devel@nongnu.org; Tue, 20 Jul 2021 10:45:18 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GThML3tLyz9sWw; Wed, 21 Jul 2021 00:45:02 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1626792302; bh=fcKQJYnRnqv2suOSu6uV5X+dpWP7ofbxtdLwaZjRmn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jZWsvyVGUjt6l2MTaMORCqDET7CCgunplAw6JlOtZ1s9IPOVjCHAem1C1kIG7QrrT Wb+8SL2wM3W5HcGVes7hE3ueCD+VwpCe2rvcsGzBLU6WNxWjmqrmGFT5TLaEY61Wza K14RDxuYwR/jfJmvE5oGcLG+FXFqN9oauvCkXGlM= Date: Tue, 20 Jul 2021 23:12:59 +1000 From: David Gibson To: Markus Armbruster Subject: Re: [PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker Message-ID: References: <20210720125408.387910-1-armbru@redhat.com> <20210720125408.387910-3-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x6ekk9CYR/ztf4gJ" Content-Disposition: inline In-Reply-To: <20210720125408.387910-3-armbru@redhat.com> Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aravinda Prasad , Ganesh Goudar , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --x6ekk9CYR/ztf4gJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 20, 2021 at 02:53:54PM +0200, Markus Armbruster wrote: > Fixes: 2500fb423adb17995485de0b4d507cf2f09e3a7f > Cc: Aravinda Prasad > Cc: Ganesh Goudar > Cc: David Gibson > Signed-off-by: Markus Armbruster Acked-by: David Gibson > --- > hw/ppc/spapr_events.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c > index 0cfc19be19..a8f2cc6bdc 100644 > --- a/hw/ppc/spapr_events.c > +++ b/hw/ppc/spapr_events.c > @@ -872,7 +872,6 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recove= red) > SpaprMachineState *spapr =3D SPAPR_MACHINE(qdev_get_machine()); > CPUState *cs =3D CPU(cpu); > int ret; > - Error *local_err =3D NULL; > =20 > if (spapr->fwnmi_machine_check_addr =3D=3D -1) { > /* Non-FWNMI case, deliver it like an architected CPU interrupt.= */ > @@ -912,7 +911,7 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recove= red) > } > } > =20 > - ret =3D migrate_add_blocker(spapr->fwnmi_migration_blocker, &local_e= rr); > + ret =3D migrate_add_blocker(spapr->fwnmi_migration_blocker, NULL); > if (ret =3D=3D -EBUSY) { > /* > * We don't want to abort so we let the migration to continue. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --x6ekk9CYR/ztf4gJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmD2y9gACgkQbDjKyiDZ s5LMxxAAl9321EIJ/nQq2zMtY9SB4U0BV2AJOs42izozVdOE7g9KB1rikB+TuxG1 LXqzNruI5CxUtxYCkmkKj5mZvz/p2tmn4SE/gpp3z81PzIlfycusSWW5Ss+kCqPu LSiarWdkzEk2PA+Dwm9k7NOBrZkbZQs2ZK168bN1ys1IEOoSFH6NrgmR10RICVOi gUCqq6MYKWx4d7M8bt2p5JshTmAigqXyEpDtYlhLSg/pdyEt03D6dp56nGNeFezv p7YQ4fgzLEf6La8YCL0cRQ49/rqWElukRdcLMHXQPeGu+78Y6E58voS8OaxJmFtq tN+QbdU5ENDpZEBWh+rbLKyFnGeeKJyTbhFRj7iwhPcmATg60vqXehiOoTq5MV5C wkBjOF+Q9rKSXHHOY9Htg3eLmYaBIorrCETDXfw/btSwo5DCNDq+krb10uhkJWPp hqDYGfFUf/N/o11jzfRKnwivuoNiFqhz/bcAFsjzFOZ525+3DZBXhH/DMBlpSyto voxOG5chpJtN3EaBTS5ybD42yuD6xWnynlpnwRLCKEGZfg2AbAuAqV7WBfQq052/ s6k+D1IGIpyHKOZwiA96UTKTGhxjaV9SHkahGbgZYnNrEQnHUriVL68c8XREaDOp 2oEXK91+12aJOM3eyOndv0GXx0LAdLp2zxu47uXEKPnRPZLmBAk= =V0Pu -----END PGP SIGNATURE----- --x6ekk9CYR/ztf4gJ--