From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1655C4338F for ; Thu, 29 Jul 2021 08:07:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D5FC61077 for ; Thu, 29 Jul 2021 08:07:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D5FC61077 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9157-0004MS-Hy for qemu-devel@archiver.kernel.org; Thu, 29 Jul 2021 04:07:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m914B-0002wK-Vz for qemu-devel@nongnu.org; Thu, 29 Jul 2021 04:06:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m914A-0005Ed-58 for qemu-devel@nongnu.org; Thu, 29 Jul 2021 04:06:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627546013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WaYQleQD+G14uKonyMY4wxN97UMxchMMmF3MBMueNXg=; b=UE3doi3pgg+HXXVNYSAk5Dz7zEjMXwFFpR8UHmhPllLFnNixzroXGijP7EJQZJoLnELpgj DrZv8i7WnKQ1zHwF65EK6BUz5pa3v8NYjjKzwKeFI6hABQvWsuZxGR8flbGQyyjq7pcDIt E3ZEe+qiO1sb/LWdMh+40mpNwHqyv+A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-bpaJtCxaPUqWGEQZxUDG-g-1; Thu, 29 Jul 2021 04:06:51 -0400 X-MC-Unique: bpaJtCxaPUqWGEQZxUDG-g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 346EB800D55; Thu, 29 Jul 2021 08:06:50 +0000 (UTC) Received: from localhost (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 221DE10016F7; Thu, 29 Jul 2021 08:06:45 +0000 (UTC) Date: Thu, 29 Jul 2021 09:06:45 +0100 From: Stefan Hajnoczi To: John Johnson Subject: Re: [PATCH RFC 03/19] vfio-user: define VFIO Proxy and communication functions Message-ID: References: <090CD4E1-D3B1-46CB-AB05-158321095D74@oracle.com> MIME-Version: 1.0 In-Reply-To: <090CD4E1-D3B1-46CB-AB05-158321095D74@oracle.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QmKxKLO9PGb283Gk" Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.719, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , Jag Raman , "swapnil.ingle@nutanix.com" , John Levon , QEMU Devel Mailing List , Alex Williamson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --QmKxKLO9PGb283Gk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 06:08:26PM +0000, John Johnson wrote: >=20 >=20 > > On Jul 27, 2021, at 9:34 AM, Stefan Hajnoczi wrot= e: > >=20 > > On Sun, Jul 18, 2021 at 11:27:42PM -0700, Elena Ufimtseva wrote: > >> From: John G Johnson > >>=20 > >> Add user.c and user.h files for vfio-user with the basic > >> send and receive functions. > >>=20 > >> Signed-off-by: John G Johnson > >> Signed-off-by: Elena Ufimtseva > >> Signed-off-by: Jagannathan Raman > >> --- > >> hw/vfio/user.h | 120 ++++++++++++++ > >> include/hw/vfio/vfio-common.h | 2 + > >> hw/vfio/user.c | 286 ++++++++++++++++++++++++++++++++++ > >> MAINTAINERS | 4 + > >> hw/vfio/meson.build | 1 + > >> 5 files changed, 413 insertions(+) > >> create mode 100644 hw/vfio/user.h > >> create mode 100644 hw/vfio/user.c > >=20 > > The multi-threading, coroutine, and blocking I/O requirements of > > vfio_user_recv() and vfio_user_send_reply() are unclear to me. Please > > document them so it's clear what environment they can be called from. I > > guess they are not called from coroutines and proxy->ioc is a blocking > > IOChannel? > >=20 >=20 > =09Yes to both, moreover, a block comment above vfio_user_recv() would > be useful. The call to setup vfio_user_recv() as the socket handler isn= =E2=80=99t > in this patch, do you want the series re-org=E2=80=99d? That would help with review, thanks! Stefan --QmKxKLO9PGb283Gk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmECYZQACgkQnKSrs4Gr c8hOsggAil8JTVa9oboq3oaQtv2LpZsL6YZEGww8X8NRiZCj8/Z8IPAwbu2W06ed iNhbvCNDjULj22tc6l2kg+j4N5kDANTrcC6dyyidYTA5KJ9K7B2b19J+xlvIvMAn mpPhL9a1I99B18kCrVaUeJasKIKQK+QH4LHlChYTGcliLXmAtQJSLlgUYfPicrfe re5wAddPHopheLjmEihcMmG4albSDMKnc5aAnp7s5hWKruBZ7yLwsviOKT7KqpvC xisnd/DNaDkITXKHOmXRTEikW4ycS0gOo1hPf2L6mw4oUxx+pLiP5aw4CpLv2UF6 MGK3mxfcXbKfRXc14zp1g0Rs3uFmig== =ZX2B -----END PGP SIGNATURE----- --QmKxKLO9PGb283Gk--