From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34123C4338F for ; Thu, 29 Jul 2021 16:34:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F125D60EFD for ; Thu, 29 Jul 2021 16:34:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F125D60EFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m98zQ-0007BK-Li for qemu-devel@archiver.kernel.org; Thu, 29 Jul 2021 12:34:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98wc-0004qZ-MR for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:31:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98wa-0001KO-SC for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:31:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627576295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n2fGwPC3bD5Nf78BpHpCBaAVhpP10wMFg/SEivtrS2M=; b=HsUvtocKGfLdWdGWGKpiiSErTaabfSdlH2jUnqXx93Jz23RzJMxd6HIDw6GhuBeMcjv6LE KsrsPgk8BTwlLTp+keP2ikBaQq+2WWlQmVsyUQyapCkNfhiuytLUxrWbyfzSd3zvP9M1N6 GUPKljBlzDABHraftQi4kkgD6kPhMUE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-atgw0-XwO0eg2ZSqbkJD6g-1; Thu, 29 Jul 2021 12:16:00 -0400 X-MC-Unique: atgw0-XwO0eg2ZSqbkJD6g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C98AA190A7A6; Thu, 29 Jul 2021 16:15:58 +0000 (UTC) Received: from localhost (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C1951007606; Thu, 29 Jul 2021 16:15:54 +0000 (UTC) Date: Thu, 29 Jul 2021 17:15:53 +0100 From: Stefan Hajnoczi To: Fabian Ebner Subject: Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN Message-ID: References: <20210729091029.65369-1-f.ebner@proxmox.com> MIME-Version: 1.0 In-Reply-To: <20210729091029.65369-1-f.ebner@proxmox.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UQvkFmE9k0HBqj8p" Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "open list:Linux io_uring" , Stefan Hajnoczi , Julia Suvorova , qemu-devel@nongnu.org, Max Reitz , Aarushi Mehta , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --UQvkFmE9k0HBqj8p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 29, 2021 at 11:10:29AM +0200, Fabian Ebner wrote: > Linux SCSI can throw spurious -EAGAIN in some corner cases in its > completion path, which will end up being the result in the completed > io_uring request. >=20 > Resubmitting such requests should allow block jobs to complete, even > if such spurious errors are encountered. >=20 > Co-authored-by: Stefan Hajnoczi > Reviewed-by: Stefano Garzarella > Signed-off-by: Fabian Ebner > --- >=20 > Changes from v1: > * Focus on what's relevant for the patch itself in the commit > message. > * Add Stefan's comment. > * Add Stefano's R-b tag (I hope that's fine, since there was no > change code-wise). >=20 > block/io_uring.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) Thanks, applied to my block tree: https://gitlab.com/stefanha/qemu/commits/block Stefan --UQvkFmE9k0HBqj8p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmEC1DkACgkQnKSrs4Gr c8hNcAf+LmWyCLQyB4qMKVnJAdUPATuNQ06dm1M5rYBHbV6cJMakOSBqT891MPx8 yGcx8kAUlZVGVL+LzwCb9CiauC9/FJk2WWLsXd4AF3OuYmiey0vEzxqHO5yQat8C Tmc7dvWglsCf53B02pIv3RrpfNAlWrQzHuv2NxLfqCPxK4CZ0z4xeTEQzypYerkz e81fFIN5iR+/u26ZgWeuMJS/QKNpwGMjXtAdSUdWSHiPmKfFW9EB9md1ZVoo2aax 9Y4Q0Nxf+7s22gn4M8TT9s4gnTTDGJH4s17uWvKCsZTEQqjZHT5e7cnHZCGLRAN3 eoQKsOtUp8eh2RbElifQ+Q+OIp1UHw== =aoJt -----END PGP SIGNATURE----- --UQvkFmE9k0HBqj8p--