From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org,
dgilbert@redhat.com, qemu-stable@nongnu.org
Subject: Re: [PATCH 1/2] hmp: Unbreak "change vnc"
Date: Thu, 9 Sep 2021 09:42:34 +0100 [thread overview]
Message-ID: <YTnI+lPmC2TDDVuP@redhat.com> (raw)
In-Reply-To: <20210909081219.308065-2-armbru@redhat.com>
On Thu, Sep 09, 2021 at 10:12:18AM +0200, Markus Armbruster wrote:
> HMP command "change vnc" can take the password as argument, or prompt
> for it:
>
> (qemu) change vnc password 123
> (qemu) change vnc password
> Password: ***
> (qemu)
>
> This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET"
> command", v6.0.0.
>
> (qemu) change vnc passwd 123
> Password: ***
> (qemu) change vnc passwd
> (qemu)
>
> The latter passes NULL to qmp_change_vnc_password(), which is a no-no.
> Looks like it puts the display into "password required, but none set"
> state.
>
> The logic error is easy to miss in review, but testing should've
> caught it.
>
> Fix the obvious way.
>
> Fixes: cfb5387a1de2acda23fb5c97d2378b9e7ddf8025
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> monitor/hmp-cmds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-09-09 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 8:12 [PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc Markus Armbruster
2021-09-09 8:12 ` [PATCH 1/2] hmp: Unbreak "change vnc" Markus Armbruster
2021-09-09 8:42 ` Daniel P. Berrangé [this message]
2021-09-23 15:03 ` Laurent Vivier
2021-09-09 8:12 ` [PATCH 2/2] hmp: Drop a bogus sentence from set_password's documentation Markus Armbruster
2021-09-09 8:42 ` Daniel P. Berrangé
2021-09-23 15:04 ` Laurent Vivier
2021-09-10 5:29 ` [PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc Gerd Hoffmann
2021-09-17 12:13 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTnI+lPmC2TDDVuP@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).