From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0497AC433F5 for ; Thu, 23 Sep 2021 20:38:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3977861164 for ; Thu, 23 Sep 2021 20:38:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3977861164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTVUW-0004kj-3p for qemu-devel@archiver.kernel.org; Thu, 23 Sep 2021 16:38:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTVPM-0008BO-78; Thu, 23 Sep 2021 16:33:28 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:41581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTVPJ-0001rn-9t; Thu, 23 Sep 2021 16:33:27 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0DDCE580C02; Thu, 23 Sep 2021 16:33:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 23 Sep 2021 16:33:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=29dI/lk/L+v2mMuoW/kv9SWIOb7 opfJ7b/6zwRYUi3A=; b=RQO88l+hjD47zu0ZD27pKT0KfvsuanJjG+VfkbE//XN 0kiembxCS0LG9LQONPSc1QiF7RyLChv6Jg/ZhH/kaYssf8v862qSFVvrUP7hxJ5t N5y2wjJ16dQJD/KX5AseA6I01fjKLHqvkP2A5G++S/Sf1M+FlI6fJ17l5chGxx/4 61APhAS+f/5fOkqL5swEICupnIjz7OCl9+0b7fm+JbQAT4bdP3hrpLahmr3qx2XY A0kTjEklyZbSjDSoYlc5qsZ0+HEJInSbJUbLYhQkK0ousSqFoZUgz5WBZ0uXb0Gt owSCKC5yZZrnqfmhrVhYDDvHaAjHnO9fv3SPot6GokA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=29dI/l k/L+v2mMuoW/kv9SWIOb7opfJ7b/6zwRYUi3A=; b=jLZC5DJypd3NAgVfunwlCS NxKkRuLp/EXugf3oR4KHa4N1T7wl87aqGQ3I8sc7nWOxC1fBCGTLeBNiPf9NVg+H L/A+cOkYR7otuEf4Wj63YsBJIKc2XXi8m9qVkWHlGI4ttpfD0TKgLtzNypJlFDno UKT6Dno3RNMWwvtE6csPItOtIbW5RJIX/vq88rignkEbfXb4bzYhG9c3vlcM/xQQ YZEzBJplaHBcqIhieFJI0aYOujo5P7vVzWq9fpwtc+x5xEDKpTYITcFrgUUFpSJr NBy578eQFCld1zFLKUw7xU9RcijaUz5gm5kTS+kLwlUxzZcBTusXxWaRo+XuPV9A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeiledgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtroertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepueeuffeihffggfetheejieevleduhfetfffhheeigfehteejieetvddtgedv hedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih htshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Sep 2021 16:33:19 -0400 (EDT) Date: Thu, 23 Sep 2021 22:33:18 +0200 From: Klaus Jensen To: Naveen Nagar Subject: Re: [RFC PATCH v2] hw/nvme:Adding Support for namespace management Message-ID: References: <1629378597-30480-1-git-send-email-naveen.n1@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nS+euLU5fMH1UYw2" Content-Disposition: inline In-Reply-To: <1629378597-30480-1-git-send-email-naveen.n1@samsung.com> Received-SPF: pass client-ip=66.111.4.229; envelope-from=its@irrelevant.dk; helo=new3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, anuj.singh@samsung.com, p.kalghatgi@samsung.com, qemu-block@nongnu.org, k.jensen@samsung.com, anaidu.gollu@samsung.com, d.palani@samsung.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, kbusch@kernel.org, prakash.v@samsung.com, raphel.david@samsung.com, jg123.choi@samsung.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --nS+euLU5fMH1UYw2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Aug 19 18:39, Naveen Nagar wrote: > From: Naveen >=20 > This patch supports namespace management : create and delete operations. >=20 > Since v1: > - Modified and moved nvme_ns_identify_common in ns.c file=20 > - Added check for CSI field in NS management > - Indentation fix in namespace create >=20 > This patch has been tested with the following command and size of image > file for unallocated namespaces is taken as 0GB. ns_create will look into > the list of unallocated namespaces and it will initialize the same and=20 > return the nsid of the same. A new mandatory field has been added called > tnvmcap and we have ensured that the total capacity of namespace created > does not exceed tnvmcap >=20 > -device nvme-subsys,id=3Dsubsys0,tnvmcap=3D8 > -device nvme,serial=3Dfoo,id=3Dnvme0,subsys=3Dsubsys0 > -device nvme,serial=3Dbar,id=3Dnvme1,subsys=3Dsubsys0 > -drive id=3Dns1,file=3Dns1.img,if=3Dnone > -device nvme-ns,drive=3Dns1,bus=3Dnvme0,nsid=3D1,zoned=3Dfalse,shared=3Dt= rue > -drive id=3Dns2,file=3Dns2.img,if=3Dnone > -device nvme-ns,drive=3Dns2,bus=3Dnvme0,nsid=3D2,zoned=3Dfalse,shared=3Dt= rue > -drive id=3Dns3,file=3Dns3.img,if=3Dnone > -device nvme-ns,drive=3Dns3,bus=3Dnvme0,nsid=3D3,zoned=3Dfalse,shared=3Dt= rue > -drive id=3Dns4,file=3Dns4.img,if=3Dnone > -device nvme-ns,drive=3Dns4,bus=3Dnvme0,nsid=3D4,zoned=3Dfalse,shared=3Dt= rue >=20 > Please review and suggest if any changes are required. >=20 > Signed-off-by: Naveen Nagar > Reviewed-by: Klaus Jensen > =20 So, I think this is a fine approach. However, I think we should let it simmer until we know if my -object refactoring will be accepted as a way forward. In that case, I'd like to only add it there and likely as a new namespace "type" (i.e. x-nvme-ns-unallocated) that will be replaced with a dynamically created object depending on CSI. --nS+euLU5fMH1UYw2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmFM5IwACgkQTeGvMW1P DemMXAf9FTqB/NefkbE0aDgn49VCAe4Tte+DRqMlDe1CpFfOZaRfko4vjMJ41t18 Npp+2CihJ+6Hxf5Aaxujl5H7tF6FzgMU1MXwanxqw5mxL5nq3fb+qDY8EJGgHOT/ 2/3upJHjzQXKr2KSwwhBZR5YlUeO4sgDHBTJZLQE02+XuNoZRuT6LmK5IQi0epJy TKHHtsYDbji3RJvU1wXyMUQmKT8yb4RfOZ2l00eaa22tIRmwTdnP9n99ej0usaj0 H8rTjZRvT3e9w1iaQvmrI0nEqe/WvWPtqMfrXgNB6kbQBSi8NctibmRxni/nlEoi jBoKAQRaV+3T625SLm/gomHvaABagA== =cIp4 -----END PGP SIGNATURE----- --nS+euLU5fMH1UYw2--