From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Pankaj Gupta" <pankaj.gupta@cloud.ionos.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
teawater <teawaterz@linux.alibaba.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Marek Kedzierski" <mkedzier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Andrey Gruzdev" <andrey.gruzdev@virtuozzo.com>,
"Wei Yang" <richard.weiyang@linux.alibaba.com>
Subject: Re: [PATCH v5 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages()
Date: Tue, 28 Sep 2021 11:34:22 -0400 [thread overview]
Message-ID: <YVM1/nyZWvYLrCeE@t490s> (raw)
In-Reply-To: <20210904160913.17785-9-david@redhat.com>
On Sat, Sep 04, 2021 at 06:09:12PM +0200, David Hildenbrand wrote:
> Let's factor out prefaulting/populating to make further changes easier to
> review and add a comment what we are actually expecting to happen. While at
> it, use the actual page size of the ramblock, which defaults to
> qemu_real_host_page_size for anonymous memory. Further, rename
> ram_block_populate_pages() to ram_block_populate_read() as well, to make
> it clearer what we are doing.
>
> In the future, we might want to use MADV_POPULATE_READ to speed up
> population.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-09-28 15:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 16:09 [PATCH v5 0/9] migration/ram: Optimize for virtio-mem via RamDiscardManager David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 1/9] memory: Introduce replay_discarded callback for RamDiscardManager David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 2/9] virtio-mem: Implement replay_discarded RamDiscardManager callback David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 3/9] migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() David Hildenbrand
2021-09-09 7:26 ` Juan Quintela
2021-09-04 16:09 ` [PATCH v5 4/9] migration/ram: Handle RAMBlocks with a RamDiscardManager on the migration source David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 5/9] virtio-mem: Drop precopy notifier David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 6/9] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 7/9] migration: Simplify alignment and alignment checks David Hildenbrand
2021-09-28 15:31 ` Peter Xu
2021-09-04 16:09 ` [PATCH v5 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages() David Hildenbrand
2021-09-28 15:34 ` Peter Xu [this message]
2021-09-28 15:34 ` David Hildenbrand
2021-09-04 16:09 ` [PATCH v5 9/9] migration/ram: Handle RAMBlocks with a RamDiscardManager on background snapshots David Hildenbrand
2021-09-28 14:01 ` [PATCH v5 0/9] migration/ram: Optimize for virtio-mem via RamDiscardManager David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVM1/nyZWvYLrCeE@t490s \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=andrey.gruzdev@virtuozzo.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mkedzier@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta@cloud.ionos.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=teawaterz@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).