From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758B2C433F5 for ; Fri, 5 Nov 2021 13:57:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2419F61165 for ; Fri, 5 Nov 2021 13:57:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2419F61165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mizit-0007Kx-6x for qemu-devel@archiver.kernel.org; Fri, 05 Nov 2021 09:57:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mizgG-0004E8-OY for qemu-devel@nongnu.org; Fri, 05 Nov 2021 09:54:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mizgD-0003dU-81 for qemu-devel@nongnu.org; Fri, 05 Nov 2021 09:54:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636120491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fGNlQufdRhvOv5Gsr8t1/OKDoIqVPsWcZiBzUYa6HUw=; b=dGCbWDSk8OIBcIw32OApf3GHUCOpuj7MjhUhX++sxFtQuw/f5iABueDyli1QjRNkFG2nJl 4yWIFGyQL0Vii5jLg8yEwiWwRjw1YRcC2ZSKa11yDpETkO5WCrhAxCPNmZoxSyNwvXuAuT rDp/EjJdfm2KwRLKT1Ze2wMiKuFJkd0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-lMHfGwW4PW2WvI17bjuWcA-1; Fri, 05 Nov 2021 09:54:47 -0400 X-MC-Unique: lMHfGwW4PW2WvI17bjuWcA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C8B487D541; Fri, 5 Nov 2021 13:54:46 +0000 (UTC) Received: from angien.pipo.sk (unknown [10.40.194.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CEDC799CF; Fri, 5 Nov 2021 13:54:17 +0000 (UTC) Date: Fri, 5 Nov 2021 14:54:15 +0100 From: Peter Krempa To: Kevin Wolf Subject: Re: [PATCH v3 03/12] vfio-user: define vfio-user-server object Message-ID: References: <13dba991f1de91711e5c3cad9a332d6e7c5eee7b.1633929457.git.jag.raman@oracle.com> <6346833B-469B-487B-8382-62EA03BA56C2@oracle.com> <87wnloce5t.fsf@dusky.pond.sub.org> <87y2623of6.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pkrempa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=pkrempa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.648, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , John Johnson , "thuth@redhat.com" , Jag Raman , "swapnil.ingle@nutanix.com" , "john.levon@nutanix.com" , "alex.bennee@linaro.org" , Markus Armbruster , qemu-devel , Alex Williamson , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Stefan Hajnoczi , "thanos.makatos@nutanix.com" , "pbonzini@redhat.com" , "philmd@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 05, 2021 at 14:19:34 +0100, Kevin Wolf wrote: > Am 05.11.2021 um 11:08 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Am 04.11.2021 um 13:13 hat Markus Armbruster geschrieben: [...] > We can deprecate on two different levels. I think it's useful to do > both: > > 1. Broad deprecation: Stable non-JSON interfaces are degraded to > a HMP-like compatibility promise. Obviously, this can only be done > for options that support JSON. Peter Maydell also wants to do this > only after a big user (read: libvirt) has implemented and is > using JSON, basically as a proof that the alternative is working. > > So this can certainly be done for -object. I believe libvirt also > uses JSON for -device now, so this should be fine now, too. Possibly > -drive (in favour of -blockdev), though I'm not completely sure if we > have gotten rid of the final users of -drive. (CCing Peter Krempa for > details.) Libvirt uses JSON exclusively with -object (starting from qemu-6.0) and with -device (starting from qemu-6.2). We could also easily do -netdev if JSON support will be added for the option as internally we already create the JSON object (so that the code is identical for QMP hotplug) and just convert it back to the commandline syntax. Libvirt also uses JSON with -blockdev since -blockdev support was introduced (IIRC qemu-4.2 added all the necessary bits for us). If -blockdev is used libvirt does not use -drive at all (except for SD cards for ARM boards), but that is not tested very well.