From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
Bin Meng <bin.meng@windriver.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Hao Wu <wuhaotsh@google.com>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: does drive_get_next(IF_NONE) make sense?
Date: Mon, 15 Nov 2021 14:24:14 +0100 [thread overview]
Message-ID: <YZJffhlo7I3sOqFs@redhat.com> (raw)
In-Reply-To: <875ysunfwz.fsf@dusky.pond.sub.org>
Am 15.11.2021 um 06:31 hat Markus Armbruster geschrieben:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > On Fri, 12 Nov 2021 at 13:34, Markus Armbruster <armbru@redhat.com> wrote:
> >>
> >> Thomas Huth <thuth@redhat.com> writes:
> >>
> >> > On 03/11/2021 09.41, Markus Armbruster wrote:
> >> >> Peter Maydell <peter.maydell@linaro.org> writes:
> >> >>
> >> >>> Does it make sense for a device/board to do drive_get_next(IF_NONE) ?
> >> >> Short answer: hell, no! ;)
> >> >
> >> > Would it make sense to add an "assert(type != IF_NONE)" to drive_get()
> >> > to avoid such mistakes in the future?
> >>
> >> Worth a try.
> >
> > You need to fix the sifive_u_otp device first :-)
>
> And for that, we may want Hao Wu's "[PATCH v4 5/7] blockdev: Add a new
> IF type IF_OTHER" first.
Same question as for Hao Wu's series: Wouldn't the proper solution be to
add a drive property to the machine type?
If you can't use -blockdev, it's not done right.
Kevin
next prev parent reply other threads:[~2021-11-15 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 15:14 does drive_get_next(IF_NONE) make sense? Peter Maydell
2021-11-02 15:28 ` Philippe Mathieu-Daudé
2021-11-03 8:41 ` Markus Armbruster
2021-11-03 9:19 ` Thomas Huth
2021-11-12 13:33 ` Markus Armbruster
2021-11-14 17:16 ` Peter Maydell
2021-11-15 5:31 ` Markus Armbruster
2021-11-15 7:12 ` Alistair Francis
2021-11-15 16:09 ` Thomas Huth
2021-11-18 13:03 ` Alistair Francis
2021-11-18 13:20 ` Peter Maydell
2021-11-15 13:24 ` Kevin Wolf [this message]
2021-11-15 13:31 ` Peter Maydell
2021-11-15 15:13 ` Kevin Wolf
2021-11-15 15:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZJffhlo7I3sOqFs@redhat.com \
--to=kwolf@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=bin.meng@windriver.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).