From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] drop libxml2 checks since libxml is not actually used (for parallels)
Date: Wed, 19 Jan 2022 17:07:09 +0000 [thread overview]
Message-ID: <YehFPYS3mMrgI1p2@stefanha-x1.localdomain> (raw)
In-Reply-To: <20220119090423.149315-1-mjt@msgid.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]
On Wed, Jan 19, 2022 at 12:04:23PM +0300, Michael Tokarev wrote:
> [This is a trivial patch, but due to the number of files it touches
> I'm not using qemu-trivial@ route.]
>
> For a long time, we assumed that libxml2 is neecessary for parallels
> block format support (block/parallels*). However, this format actually
> does not use libxml. Since this is the only user of libxml2 in while
> qemu tree, we can drop all libxml2 checks and dependencies too.
>
> It is even more: --enable-parallels configure option was the only
> option which was silently ignored when it's (fake) dependency
> (libxml2) isn't installed.
>
> Drop all mentions of libxml2.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> .cirrus.yml | 1 -
> .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-
> .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
> .gitlab-ci.d/cirrus/macos-11.vars | 2 +-
> .gitlab-ci.d/windows.yml | 2 --
> block/meson.build | 3 +--
> meson.build | 6 ------
> meson_options.txt | 2 --
> scripts/ci/org.centos/stream/8/x86_64/configure | 1 -
> scripts/coverity-scan/coverity-scan.docker | 1 -
> scripts/coverity-scan/run-coverity-scan | 2 +-
> tests/docker/dockerfiles/alpine.docker | 1 -
> tests/docker/dockerfiles/centos8.docker | 1 -
> tests/docker/dockerfiles/fedora.docker | 1 -
> tests/docker/dockerfiles/opensuse-leap.docker | 1 -
> tests/docker/dockerfiles/ubuntu1804.docker | 1 -
> tests/docker/dockerfiles/ubuntu2004.docker | 1 -
> 17 files changed, 5 insertions(+), 25 deletions(-)
Nice cleanup.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-01-19 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 9:04 [PATCH] drop libxml2 checks since libxml is not actually used (for parallels) Michael Tokarev
2022-01-19 9:35 ` Daniel P. Berrangé
2022-01-19 9:41 ` Denis V. Lunev
2022-01-19 17:07 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YehFPYS3mMrgI1p2@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).