From: "Daniel P. Berrangé" <berrange@redhat.com>
To: casantos@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] tracing: install trace events file only if necessary
Date: Mon, 27 Mar 2023 10:23:43 +0100 [thread overview]
Message-ID: <ZCFgnySXy4TdPyQD@redhat.com> (raw)
In-Reply-To: <20230326210446.66170-1-casantos@redhat.com>
On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote:
> From: Carlos Santos <casantos@redhat.com>
>
> It is required only if linux-user, bsd-user or system emulator is built.
>
> Signed-off-by: Carlos Santos <casantos@redhat.com>
> ---
> trace/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace/meson.build b/trace/meson.build
> index 8e80be895c..3fb41c97a4 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
> input: trace_events_files,
> command: [ 'cat', '@INPUT@' ],
> capture: true,
> - install: true,
> + install: have_linux_user or have_bsd_user or have_system,
Trace events are used by our command line tools too qemu-img, qemu-io,
qemu-nbd, qemu-pr-helper, qemu-storage-daemon.
What build scenario are you seeing that does NOT want the trace events
to be present ? If there is any, then I might even call that situation
a bug, as we want trace events to be available as a debugging mechanism
for everything we build.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-27 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 21:04 [PATCH] tracing: install trace events file only if necessary casantos
2023-03-27 9:23 ` Daniel P. Berrangé [this message]
2023-03-27 14:28 ` Carlos Santos
2023-03-27 14:42 ` Daniel P. Berrangé
2023-03-27 14:44 ` Carlos Santos
2023-03-27 17:31 ` Carlos Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCFgnySXy4TdPyQD@redhat.com \
--to=berrange@redhat.com \
--cc=casantos@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).