From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86E32C76195 for ; Mon, 27 Mar 2023 14:43:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgo3P-0004Xq-7b; Mon, 27 Mar 2023 10:42:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgo3N-0004XM-Kr for qemu-devel@nongnu.org; Mon, 27 Mar 2023 10:42:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgo3L-0006rB-NT for qemu-devel@nongnu.org; Mon, 27 Mar 2023 10:42:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679928150; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5vq2TnFdyJ2wECGnQNQgYaxJF+4i91l3uy5wERUrOE=; b=KgGM9DhddcoxFtyQrumgwGm507H21/cLX9Gv2a5gQxDWzDvqIkqq5ATkf1xcp8Hmiqz/xD QSbJz6xzIkBJaF0fwMyiEZVpjeNtuZlAD47AA4batInqfwOuUqMDyfXypESHtTnVJlJ5dV Yzpc9p3S6rV5JypWglCIaZld+CQ6rW0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-Ob2mcNOVN5ywbbqw_iyQpQ-1; Mon, 27 Mar 2023 10:42:26 -0400 X-MC-Unique: Ob2mcNOVN5ywbbqw_iyQpQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 602171C0A59D for ; Mon, 27 Mar 2023 14:42:26 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.173]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C86C51121330; Mon, 27 Mar 2023 14:42:25 +0000 (UTC) Date: Mon, 27 Mar 2023 15:42:23 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Carlos Santos Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] tracing: install trace events file only if necessary Message-ID: References: <20230326210446.66170-1-casantos@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Mar 27, 2023 at 11:28:05AM -0300, Carlos Santos wrote: > On Mon, Mar 27, 2023 at 6:23 AM Daniel P. Berrangé wrote: > > > > On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote: > > > From: Carlos Santos > > > > > > It is required only if linux-user, bsd-user or system emulator is built. > > > > > > Signed-off-by: Carlos Santos > > > --- > > > trace/meson.build | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/trace/meson.build b/trace/meson.build > > > index 8e80be895c..3fb41c97a4 100644 > > > --- a/trace/meson.build > > > +++ b/trace/meson.build > > > @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all', > > > input: trace_events_files, > > > command: [ 'cat', '@INPUT@' ], > > > capture: true, > > > - install: true, > > > + install: have_linux_user or have_bsd_user or have_system, > > > > Trace events are used by our command line tools too qemu-img, qemu-io, > > qemu-nbd, qemu-pr-helper, qemu-storage-daemon. > > > > What build scenario are you seeing that does NOT want the trace events > > to be present ? If there is any, then I might even call that situation > > a bug, as we want trace events to be available as a debugging mechanism > > for everything we build. > > I'm aiming for an embedded system or a VM image that only needs > qemu-ga, in which qemu is built with --enable-trace-backends=nop. How about install: get_option('trace_backends') != 'nop' ? With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|