From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: "qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "fam@euphon.net" <fam@euphon.net>,
"kwolf@redhat.com" <kwolf@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters
Date: Wed, 14 Aug 2019 16:54:43 +0000 [thread overview]
Message-ID: <a018756a-fa67-49fb-a7db-622267b7d4e5@email.android.com> (raw)
In-Reply-To: <20190814144315.89729-1-vsementsov@virtuozzo.com>
14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> написал:
Hi all!
There is a bug in not yet merged patch
"block/backup: teach TOP to never copy unallocated regions"
in https://github.com/jnsnow/qemu bitmaps. 04 fixes it. So, I propose
to put 01-03 somewhere before
"block/backup: teach TOP to never copy unallocated regions"
and squash 04 into "block/backup: teach TOP to never copy unallocated regions"
Hmm, don't bother with it. Simpler is fix the bug in your commit by just use skip_bytes variable when initializing dirty_end.
Based-on: https://github.com/jnsnow/qemu bitmaps
Vladimir Sementsov-Ogievskiy (4):
block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t
block/dirty-bitmap: add _next_dirty API
block/backup: use bdrv_dirty_bitmap_next_dirty
block/backup: fix and improve skipping unallocated in backup_do_cow
include/block/dirty-bitmap.h | 8 ++--
include/qemu/hbitmap.h | 18 +++++++--
block/backup.c | 33 ++++++++++-------
block/dirty-bitmap.c | 12 ++++--
block/mirror.c | 4 +-
tests/test-hbitmap.c | 32 ++++++++--------
util/hbitmap.c | 72 ++++++++++++++++++++----------------
block/trace-events | 1 -
8 files changed, 107 insertions(+), 73 deletions(-)
--
2.18.0
next prev parent reply other threads:[~2019-08-14 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 14:43 [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters Vladimir Sementsov-Ogievskiy
2019-08-14 14:43 ` [Qemu-devel] [PATCH 1/4] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t Vladimir Sementsov-Ogievskiy
2019-08-14 14:43 ` [Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add _next_dirty API Vladimir Sementsov-Ogievskiy
2019-08-14 14:43 ` [Qemu-devel] [PATCH 3/4] block/backup: use bdrv_dirty_bitmap_next_dirty Vladimir Sementsov-Ogievskiy
2019-08-14 14:43 ` [Qemu-devel] [PATCH 4/4] block/backup: fix and improve skipping unallocated in backup_do_cow Vladimir Sementsov-Ogievskiy
2019-08-14 16:54 ` Vladimir Sementsov-Ogievskiy [this message]
2019-08-16 19:11 ` [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters John Snow
2019-08-20 8:28 ` Vladimir Sementsov-Ogievskiy
2019-08-20 19:30 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a018756a-fa67-49fb-a7db-622267b7d4e5@email.android.com \
--to=vsementsov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).