From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AABEECE587 for ; Tue, 1 Oct 2019 21:23:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D29D21783 for ; Tue, 1 Oct 2019 21:23:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D29D21783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFPcS-0002It-GU for qemu-devel@archiver.kernel.org; Tue, 01 Oct 2019 17:23:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56647) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFOIy-0007GA-2Y for qemu-devel@nongnu.org; Tue, 01 Oct 2019 15:59:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFOIw-0005GK-4v for qemu-devel@nongnu.org; Tue, 01 Oct 2019 15:59:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33710) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFOIv-0005En-Vh for qemu-devel@nongnu.org; Tue, 01 Oct 2019 15:59:26 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2BFB308339B; Tue, 1 Oct 2019 19:59:23 +0000 (UTC) Received: from [10.3.116.201] (ovpn-116-201.phx2.redhat.com [10.3.116.201]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D359261AA; Tue, 1 Oct 2019 19:59:21 +0000 (UTC) Subject: Re: [PATCH 1/7] qapi: Don't suppress doc generation without pragma doc-required To: Markus Armbruster , qemu-devel@nongnu.org References: <20191001191514.11208-1-armbru@redhat.com> <20191001191514.11208-2-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Tue, 1 Oct 2019 14:59:20 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191001191514.11208-2-armbru@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 01 Oct 2019 19:59:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/1/19 2:15 PM, Markus Armbruster wrote: > Commit bc52d03ff5 "qapi: Make doc comments optional where we don't > need them" made scripts/qapi2texi.py fail[*] unless the schema had > pragma 'doc-required': true. The stated reason was inability to cope > with incomplete documentation. > > When commit fb0bc835e5 "qapi-gen: New common driver for code and doc > generators" folded scripts/qapi2texi.py into scripts/qapi-gen.py, it > turned the failure into silent suppression. > > The doc generator can cope with incomplete documentation now. I don't > know since when, or what the problem was, or even whether it ever > existed. > > Drop the silent suppression. > > [*] The fail part was broken, fixed in commit e8ba07ea9a. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/doc.py | 2 -- > tests/Makefile.include | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org