From: Paolo Bonzini <pbonzini@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr
Date: Thu, 18 Jul 2019 13:08:13 +0200 [thread overview]
Message-ID: <a411dc3f-3b9d-8977-0ec4-dc0e8456af51@redhat.com> (raw)
In-Reply-To: <20190718103951.10027-1-npiggin@gmail.com>
On 18/07/19 12:39, Nicholas Piggin wrote:
> Any comments on this series would be welcome. Hopefully someone who
> knows i386 can give some feedback on the possible bug fix, and
> whether the new wakeup method will suit i386.
Looks good, though only i386 supports wakeup so perhaps it's better to
DTRT and move the reset to the PC machine's wakeup method. Then pseries
need not implement mc->wakeup at all.
Paolo
> Thanks,
> Nick
>
> Nicholas Piggin (3):
> qmp: don't emit the RESET event on wakeup
> machine: Add wakeup method to MachineClass
> spapr: Implement ibm,suspend-me
>
> hw/ppc/spapr.c | 11 +++++++++++
> hw/ppc/spapr_rtas.c | 32 ++++++++++++++++++++++++++++++++
> include/hw/boards.h | 1 +
> include/hw/ppc/spapr.h | 3 ++-
> vl.c | 31 +++++++++++++++++++++++++++++--
> 5 files changed, 75 insertions(+), 3 deletions(-)
>
next prev parent reply other threads:[~2019-07-18 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 10:39 [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr Nicholas Piggin
2019-07-18 10:39 ` [Qemu-devel] [PATCH 1/3] qmp: don't emit the RESET event on wakeup Nicholas Piggin
2019-07-18 11:06 ` Paolo Bonzini
2019-07-18 11:27 ` Christian Borntraeger
2019-07-18 23:24 ` Nicholas Piggin
2019-07-19 7:33 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-07-19 9:19 ` [Qemu-devel] " Cornelia Huck
2019-07-18 10:39 ` [Qemu-devel] [PATCH 2/3] machine: Add wakeup method to MachineClass Nicholas Piggin
2019-07-18 10:39 ` [Qemu-devel] [PATCH 3/3] spapr: Implement ibm,suspend-me Nicholas Piggin
2019-07-18 11:08 ` Paolo Bonzini [this message]
2019-07-18 23:25 ` [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a411dc3f-3b9d-8977-0ec4-dc0e8456af51@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).