From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C10D6C433B4 for ; Mon, 17 May 2021 17:16:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7220A61285 for ; Mon, 17 May 2021 17:16:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7220A61285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ligqa-0008JE-IZ for qemu-devel@archiver.kernel.org; Mon, 17 May 2021 13:16:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ligpK-0006AM-IC for qemu-devel@nongnu.org; Mon, 17 May 2021 13:14:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ligpI-0006jO-FW for qemu-devel@nongnu.org; Mon, 17 May 2021 13:14:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621271683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPTz4XzVjK3r2tliPpjGmSntptw6o93MVcyP9AEJhhA=; b=TL72luZ1uGWLht1JNPavUrpKbJEzY8OgAxeKjUN9cGcUZfP5+sOBOWZItZLCJ6axoTGoQK QDbtbRq7Wl2m1/W+wzLL7MC9VvYill12TL/AVAGofYQEX08y/Wxiq888uHNrq9FpfS6qS4 7kwvkyl7mW/9drDHFqiAXZqMFyTsA2k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-o6oZzqDsOUCx8Wm-DrCzyA-1; Mon, 17 May 2021 13:14:40 -0400 X-MC-Unique: o6oZzqDsOUCx8Wm-DrCzyA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B2911854E25; Mon, 17 May 2021 17:14:39 +0000 (UTC) Received: from [10.10.117.64] (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9943660BE5; Mon, 17 May 2021 17:14:37 +0000 (UTC) Subject: Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196) To: P J P , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210123100345.642933-1-ppandit@redhat.com> <6881ef3c-99a1-1f5f-cca5-0850ec2bd6cf@redhat.com> <89fb8d54-707a-9965-75e2-665d4cb07d63@redhat.com> <8n7o47n5-741n-819-187-n27p1o87q362@erqung.pbz> From: John Snow Message-ID: Date: Mon, 17 May 2021 13:14:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8n7o47n5-741n-819-187-n27p1o87q362@erqung.pbz> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , Qemu-block , QEMU Developers , qemu-stable@nongnu.org, Max Reitz , Gaoning Pan Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/17/21 7:12 AM, P J P wrote: > +-- On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote --+ > | This patch misses the qtest companion with the reproducer > | provided by Alexander. > > Do we need a revised patch[-series] including a qtest? OR it can be done at > merge time? > > Thank you. > -- > - P J P > 8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D > Unknown, haven't dug into this patch and problem yet. If you have the time to write a qtest reproducer, you can send it separately and I'll pick it up if everything looks correct. Sorry for the FDC/ATA delays. Working on it. (...Maintainers wanted!) --js