From: Jason Wang <jasowang@redhat.com>
To: Zhang Chen <chen.zhang@intel.com>
Cc: "Lukas Straub" <lukasstraub2@web.de>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
qemu-dev <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PULL V2 1/6] qapi/net: Add IPFlowSpec and QMP command for filter passthrough
Date: Fri, 9 Jul 2021 11:52:33 +0800 [thread overview]
Message-ID: <a49385c6-5ccc-42db-b3ca-0f81b5734f05@redhat.com> (raw)
In-Reply-To: <20210701091130.3022093-2-chen.zhang@intel.com>
在 2021/7/1 下午5:11, Zhang Chen 写道:
> Since the real user scenario does not need to monitor all traffic.
> Add passthrough-filter-add and passthrough-filter-del to maintain
> a network passthrough list in object with network packet processing
> function. Add IPFlowSpec struct for all QMP commands.
> Most the fields of IPFlowSpec are optional,except object-name.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Hi:
I would like to have ack from the QAPI guys for this patch.
Thanks
> ---
> net/net.c | 10 +++++++
> qapi/net.json | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 88 insertions(+)
>
> diff --git a/net/net.c b/net/net.c
> index 76bbb7c31b..00f2be7a58 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1195,6 +1195,16 @@ void qmp_netdev_del(const char *id, Error **errp)
> }
> }
>
> +void qmp_passthrough_filter_add(IPFlowSpec *spec, Error **errp)
> +{
> + /* TODO implement setup passthrough rule */
> +}
> +
> +void qmp_passthrough_filter_del(IPFlowSpec *spec, Error **errp)
> +{
> + /* TODO implement delete passthrough rule */
> +}
> +
> static void netfilter_print_info(Monitor *mon, NetFilterState *nf)
> {
> char *str;
> diff --git a/qapi/net.json b/qapi/net.json
> index 7fab2e7cd8..bfe38faab5 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -7,6 +7,7 @@
> ##
>
> { 'include': 'common.json' }
> +{ 'include': 'sockets.json' }
>
> ##
> # @set_link:
> @@ -696,3 +697,80 @@
> ##
> { 'event': 'FAILOVER_NEGOTIATED',
> 'data': {'device-id': 'str'} }
> +
> +##
> +# @IPFlowSpec:
> +#
> +# IP flow specification.
> +#
> +# @protocol: Transport layer protocol like TCP/UDP, etc. The protocol is the
> +# string instead of enum, because it can be passed to getprotobyname(3)
> +# and avoid duplication with /etc/protocols.
> +#
> +# @object-name: The @object-name means a qemu object with network packet
> +# processing function, for example colo-compare, filtr-redirector
> +# filtr-mirror, etc. VM can running with multi network packet
> +# processing function objects. They can control different network
> +# data paths from netdev or chardev. So it needs the object-name
> +# to set the effective module.
> +#
> +# @source: Source address and port.
> +#
> +# @destination: Destination address and port.
> +#
> +# Since: 6.1
> +##
> +{ 'struct': 'IPFlowSpec',
> + 'data': { '*protocol': 'str', 'object-name': 'str',
> + '*source': 'InetSocketAddressBase',
> + '*destination': 'InetSocketAddressBase' } }
> +
> +##
> +# @passthrough-filter-add:
> +#
> +# Add passthrough entry IPFlowSpec to a qemu object with network packet
> +# processing function, for example filtr-mirror, COLO-compare, etc.
> +# The object-name is necessary. The protocol and source/destination IP and
> +# source/destination ports are optional. if only inputs part of the
> +# information, it will match all traffic.
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 6.1
> +#
> +# Example:
> +#
> +# -> { "execute": "passthrough-filter-add",
> +# "arguments": { "protocol": "tcp", "object-name": "object0",
> +# "source": {"host": "192.168.1.1", "port": "1234"},
> +# "destination": {"host": "192.168.1.2", "port": "4321"} } }
> +# <- { "return": {} }
> +#
> +##
> +{ 'command': 'passthrough-filter-add', 'boxed': true,
> + 'data': 'IPFlowSpec' }
> +
> +##
> +# @passthrough-filter-del:
> +#
> +# Delete passthrough entry IPFlowSpec to a qemu object with network packet
> +# processing function, for example filtr-mirror, COLO-compare, etc.
> +# The object-name is necessary. The protocol and source/destination IP and
> +# source/destination ports are optional. if only inputs part of the
> +# information, only the exact same rule will be deleted.
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 6.1
> +#
> +# Example:
> +#
> +# -> { "execute": "passthrough-filter-del",
> +# "arguments": { "protocol": "tcp", "object-name": "object0",
> +# "source": {"host": "192.168.1.1", "port": "1234"},
> +# "destination": {"host": "192.168.1.2", "port": "4321"} } }
> +# <- { "return": {} }
> +#
> +##
> +{ 'command': 'passthrough-filter-del', 'boxed': true,
> + 'data': 'IPFlowSpec' }
next prev parent reply other threads:[~2021-07-09 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 9:11 [PULL V2 0/6] COLO-Proxy patches for 2021-06-25 Zhang Chen
2021-07-01 9:11 ` [PULL V2 1/6] qapi/net: Add IPFlowSpec and QMP command for filter passthrough Zhang Chen
2021-07-09 3:52 ` Jason Wang [this message]
2021-07-09 5:56 ` Zhang, Chen
2021-07-01 9:11 ` [PULL V2 2/6] util/qemu-sockets.c: Add inet_parse_base to handle InetSocketAddressBase Zhang Chen
2021-07-01 9:11 ` [PULL V2 3/6] hmp-commands: Add new HMP command for filter passthrough Zhang Chen
2021-07-14 18:47 ` Dr. David Alan Gilbert
2021-07-15 3:07 ` Zhang, Chen
2021-07-15 4:20 ` Jason Wang
2021-07-19 9:00 ` Zhang, Chen
2021-07-01 9:11 ` [PULL V2 4/6] net/colo-compare: Move data structure and define to .h file Zhang Chen
2021-07-01 9:11 ` [PULL V2 5/6] net/colo-compare: Add passthrough list to CompareState Zhang Chen
2021-07-01 9:11 ` [PULL V2 6/6] net/net.c: Add handler for passthrough filter command Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49385c6-5ccc-42db-b3ca-0f81b5734f05@redhat.com \
--to=jasowang@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).