qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
@ 2021-08-27 15:17 Thomas Huth
  2021-08-27 15:22 ` Daniel P. Berrangé
  2021-08-27 15:49 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2021-08-27 15:17 UTC (permalink / raw)
  To: David Gibson, qemu-devel; +Cc: qemu-arm, qemu-ppc

libfdt in Debian is too old to be usable for QEMU. So far we were
silently falling back to the internal dtc submodule, but since
this is wrong, let's remove the --enable-fdt=system switch here now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Sorry, I just noticed this after sending out the first three patches already

 .gitlab-ci.d/buildtest.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 903ee65f32..f0eb5f6286 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -74,7 +74,6 @@ build-system-debian:
     job: amd64-debian-container
   variables:
     IMAGE: debian-amd64
-    CONFIGURE_ARGS: --enable-fdt=system
     TARGETS: arm-softmmu avr-softmmu i386-softmmu mipsel-softmmu
       riscv64-softmmu sh4eb-softmmu sparc-softmmu xtensaeb-softmmu
     MAKE_CHECK_ARGS: check-build
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
  2021-08-27 15:17 [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Thomas Huth
@ 2021-08-27 15:22 ` Daniel P. Berrangé
  2021-08-27 15:49 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2021-08-27 15:22 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-arm, qemu-ppc, qemu-devel, David Gibson

On Fri, Aug 27, 2021 at 05:17:18PM +0200, Thomas Huth wrote:
> libfdt in Debian is too old to be usable for QEMU. So far we were
> silently falling back to the internal dtc submodule, but since
> this is wrong, let's remove the --enable-fdt=system switch here now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Sorry, I just noticed this after sending out the first three patches already
> 
>  .gitlab-ci.d/buildtest.yml | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
  2021-08-27 15:17 [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Thomas Huth
  2021-08-27 15:22 ` Daniel P. Berrangé
@ 2021-08-27 15:49 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-08-27 15:49 UTC (permalink / raw)
  To: Thomas Huth, David Gibson, qemu-devel; +Cc: qemu-arm, qemu-ppc

On 8/27/21 5:17 PM, Thomas Huth wrote:
> libfdt in Debian is too old to be usable for QEMU. So far we were
> silently falling back to the internal dtc submodule, but since
> this is wrong, let's remove the --enable-fdt=system switch here now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Sorry, I just noticed this after sending out the first three patches already
> 
>  .gitlab-ci.d/buildtest.yml | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
  2021-08-27 12:08 [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1 Thomas Huth
@ 2021-08-27 15:17 ` Thomas Huth
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2021-08-27 15:17 UTC (permalink / raw)
  To: David Gibson, qemu-devel; +Cc: qemu-arm, qemu-ppc

libfdt in Debian is too old to be usable for QEMU. So far we were
silently falling back to the internal dtc submodule, but since
this is wrong, let's remove the --enable-fdt=system switch here now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Sorry, I just noticed this after sending out the first three patches already

 .gitlab-ci.d/buildtest.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 903ee65f32..f0eb5f6286 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -74,7 +74,6 @@ build-system-debian:
     job: amd64-debian-container
   variables:
     IMAGE: debian-amd64
-    CONFIGURE_ARGS: --enable-fdt=system
     TARGETS: arm-softmmu avr-softmmu i386-softmmu mipsel-softmmu
       riscv64-softmmu sh4eb-softmmu sparc-softmmu xtensaeb-softmmu
     MAKE_CHECK_ARGS: check-build
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-27 15:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 15:17 [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Thomas Huth
2021-08-27 15:22 ` Daniel P. Berrangé
2021-08-27 15:49 ` Philippe Mathieu-Daudé
  -- strict thread matches above, loose matches on Subject: below --
2021-08-27 12:08 [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1 Thomas Huth
2021-08-27 15:17 ` [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).