From: Laurent Vivier <laurent@vivier.eu>
To: Matus Kysel <mkysel@tachyum.com>
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2] linux-user: strace now handles unshare syscall args correctly
Date: Tue, 6 Apr 2021 16:46:05 +0200 [thread overview]
Message-ID: <a5930034-94bc-80e9-0bee-d2f33cb8f6fc@vivier.eu> (raw)
In-Reply-To: <20210406144203.1020598-1-mkysel@tachyum.com>
Le 06/04/2021 à 16:42, Matus Kysel a écrit :
> Syscall unshare did not have custom print function for strace, but it's argument is same as flags in clone syscall, so it can be easily implemented.
> Also updated missing flags from clone_flags.
>
> Signed-off-by: Matus Kysel <mkysel@tachyum.com>
> ---
> linux-user/strace.c | 18 ++++++++++++++++++
> linux-user/strace.list | 2 +-
> 2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index e969121b6c..1cadb6d50f 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1109,6 +1109,12 @@ UNUSED static struct flags clone_flags[] = {
> #if defined(CLONE_NEWNET)
> FLAG_GENERIC(CLONE_NEWNET),
> #endif
> +#if defined(CLONE_NEWCGROUP)
> + FLAG_GENERIC(CLONE_NEWCGROUP),
> +#endif
> +#if defined(CLONE_NEWTIME)
> + FLAG_GENERIC(CLONE_NEWTIME),
> +#endif
> #if defined(CLONE_IO)
> FLAG_GENERIC(CLONE_IO),
> #endif
> @@ -3467,6 +3473,18 @@ print_unlinkat(void *cpu_env, const struct syscallname *name,
> }
> #endif
>
> +#ifdef TARGET_NR_unshare
> +static void
> +print_unshare(void *cpu_env, const struct syscallname *name,
> + abi_long arg0, abi_long arg1, abi_long arg2,
> + abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> + print_syscall_prologue(name);
> + print_flags(clone_flags, arg0, 1);
> + print_syscall_epilogue(name);
> +}
> +#endif
> +
> #ifdef TARGET_NR_utime
> static void
> print_utime(void *cpu_env, const struct syscallname *name,
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index 084048ab96..3b7c15578c 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -1573,7 +1573,7 @@
> { TARGET_NR_unlinkat, "unlinkat" , NULL, print_unlinkat, NULL },
> #endif
> #ifdef TARGET_NR_unshare
> -{ TARGET_NR_unshare, "unshare" , NULL, NULL, NULL },
> +{ TARGET_NR_unshare, "unshare" , NULL, print_unshare, NULL },
> #endif
> #ifdef TARGET_NR_userfaultfd
> { TARGET_NR_userfaultfd, "userfaultfd" , NULL, NULL, NULL },
> --
> 2.25.1
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2021-04-06 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 14:42 [PATCH v2] linux-user: strace now handles unshare syscall args correctly Matus Kysel
2021-04-06 14:46 ` Laurent Vivier [this message]
2021-05-15 19:35 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5930034-94bc-80e9-0bee-d2f33cb8f6fc@vivier.eu \
--to=laurent@vivier.eu \
--cc=mkysel@tachyum.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).