From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi
Subject: Re: [PULL 0/5] Linux user for 5.0 patches
Date: Tue, 24 Mar 2020 12:06:44 +0100 [thread overview]
Message-ID: <a5bb378b-d51b-fa9f-8e55-172adebb2e0b@vivier.eu> (raw)
In-Reply-To: <158504763369.13426.12844033914999219295@39012742ff91>
Le 24/03/2020 à 12:00, no-reply@patchew.org a écrit :
> Patchew URL: https://patchew.org/QEMU/20200324100311.588288-1-laurent@vivier.eu/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [PULL 0/5] Linux user for 5.0 patches
> Message-id: 20200324100311.588288-1-laurent@vivier.eu
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Switched to a new branch 'test'
> 58fa059 linux-user: Flush out implementation of gettimeofday
> f253e7a linux-user: Add x86_64 vsyscall page to /proc/self/maps
> ad06327 linux-user/i386: Emulate x86_64 vsyscalls
> 2dccb44 linux-user/i386: Split out gen_signal
> 1ab05c1 target/i386: Renumber EXCP_SYSCALL
>
> === OUTPUT BEGIN ===
> 1/5 Checking commit 1ab05c10ed02 (target/i386: Renumber EXCP_SYSCALL)
> 2/5 Checking commit 2dccb4427740 (linux-user/i386: Split out gen_signal)
> 3/5 Checking commit ad0632716d07 (linux-user/i386: Emulate x86_64 vsyscalls)
> 4/5 Checking commit f253e7a47cf4 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
> ERROR: trailing whitespace
> #32: FILE: linux-user/syscall.c:7152:
> + dprintf(fd, TARGET_FMT_lx "-" TARGET_FMT_lx $
>
> total: 1 errors, 0 warnings, 16 lines checked
>
> Patch 4/5 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 5/5 Checking commit 58fa0592ae77 (linux-user: Flush out implementation of gettimeofday)
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
> http://patchew.org/logs/20200324100311.588288-1-laurent@vivier.eu/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
>
Sorry, fixed that on previous PR, not in this new one.
I'm going to send a v2 shortly.
Thanks,
Laurent
next prev parent reply other threads:[~2020-03-24 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:03 [PULL 0/5] Linux user for 5.0 patches Laurent Vivier
2020-03-24 10:03 ` [PULL 1/5] target/i386: Renumber EXCP_SYSCALL Laurent Vivier
2020-03-24 10:03 ` [PULL 2/5] linux-user/i386: Split out gen_signal Laurent Vivier
2020-03-24 10:03 ` [PULL 3/5] linux-user/i386: Emulate x86_64 vsyscalls Laurent Vivier
2020-03-24 10:03 ` [PULL 4/5] linux-user: Add x86_64 vsyscall page to /proc/self/maps Laurent Vivier
2020-03-24 10:03 ` [PULL 5/5] linux-user: Flush out implementation of gettimeofday Laurent Vivier
2020-03-24 11:00 ` [PULL 0/5] Linux user for 5.0 patches no-reply
2020-03-24 11:06 ` Laurent Vivier [this message]
2020-03-24 12:32 ` no-reply
-- strict thread matches above, loose matches on Subject: below --
2020-02-13 12:21 Laurent Vivier
2020-02-14 17:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5bb378b-d51b-fa9f-8e55-172adebb2e0b@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).