From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AB5C4361B for ; Thu, 17 Dec 2020 13:05:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A8312389E for ; Thu, 17 Dec 2020 13:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A8312389E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpsyW-0001Pr-4k for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 08:05:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpswq-0000rT-Ad for qemu-devel@nongnu.org; Thu, 17 Dec 2020 08:04:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpswm-0002L4-SM for qemu-devel@nongnu.org; Thu, 17 Dec 2020 08:03:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608210235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EkKdmd14drS91m6Rf0CJds3xskbRaAKRMgnld/YVI08=; b=V5xE9oPXs2ui8NhhVbcNAOM0qPe9Kd2Kx3Z3on0qGMxBc38Pks8eeoMnxgU4ZwthoZCvFS wDEGLKx7HBlu9IyhHBNcXp/z20HedHSvXW0DYwm6MpPA/nwIwKN/j9AHTljItyp+KhFQyU FcDPClQLl9nX2TOPFU3o41ETJKu5y6k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-lO6aAXNdMu6YkSsFNuOLLQ-1; Thu, 17 Dec 2020 08:03:51 -0500 X-MC-Unique: lO6aAXNdMu6YkSsFNuOLLQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C678451081; Thu, 17 Dec 2020 13:03:49 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id C627B5F9C8; Thu, 17 Dec 2020 13:03:47 +0000 (UTC) Subject: Re: [PULL 00/12] Compile QEMU with -Wimplicit-fallthrough To: Peter Maydell References: <20201216172949.57380-1-thuth@redhat.com> From: Thomas Huth Message-ID: Date: Thu, 17 Dec 2020 14:03:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ed Maste , QEMU Developers , Kamil Rytarowski , "Daniel P. Berrange" , Chen Qun , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Li-Wen Hsu , Brad Smith Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17/12/2020 13.51, Peter Maydell wrote: > On Wed, 16 Dec 2020 at 17:29, Thomas Huth wrote: >> >> Hi! >> >> The following changes since commit af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: >> >> Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-12-15 21:24:31 +0000) >> >> are available in the Git repository at: >> >> https://gitlab.com/huth/qemu.git tags/pull-request-2020-12-16 >> >> for you to fetch changes up to cbbedfeeb77e25b065f8a2b0c33e81403edaf728: >> >> configure: Compile with -Wimplicit-fallthrough=2 (2020-12-16 12:52:20 +0100) >> >> ---------------------------------------------------------------- >> * Compile QEMU with -Wimplicit-fallthrough=2 to avoid bugs in >> switch-case statements >> ---------------------------------------------------------------- > > Hi; this generates a new warning on the NetBSD build: > > ../src/bsd-user/main.c: In function 'cpu_loop': > ../src/bsd-user/main.c:513:16: warning: this statement may fall > through [-Wimplicit-fallthrough=] > if (bsd_type != target_freebsd) > ^ > ../src/bsd-user/main.c:515:9: note: here > case 0x100: > ^~~~ Oh man, can't we just ditch the bsd-user folder now? It's known to be broken since many releases, so it's currently only causing additional effort to keep this code compilable (also with regards to the automatic code scan tool reports that we've seen during the past months), without real benefit. Even if the BSD folks finally upstream their fixed version again, it's more likely that they will start from scratch again instead of fixing the old folder, I guess? Thomas