From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25906C433F5 for ; Thu, 28 Oct 2021 16:14:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8F6A60FC4 for ; Thu, 28 Oct 2021 16:14:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8F6A60FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mg82R-0008Du-TN for qemu-devel@archiver.kernel.org; Thu, 28 Oct 2021 12:13:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg7mj-00050a-Q7 for qemu-devel@nongnu.org; Thu, 28 Oct 2021 11:57:45 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:43593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mg7mi-0004W5-4t for qemu-devel@nongnu.org; Thu, 28 Oct 2021 11:57:45 -0400 Received: by mail-pg1-x529.google.com with SMTP id r2so6772598pgl.10 for ; Thu, 28 Oct 2021 08:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XDDkQeHZ0dijGtSKlhGqjNUEl29/r8+MY+SRNPeDCrg=; b=iyCPo4L2ip3tRO/molwyZg9mVUEzrWwGaEEPrJ/GUqS4lMESbwuTM3VbeYsl1bnkXZ txewQdHGw927iCEwKyurt1NFIXAsc2N8ndEdp7kVhb2siiXo45+JvioLlasW0yKO9WxT AmfC9bM9PEIcJRVTAX6yEAh2yb4swZ2iBaYil8zJtMTuPYVTYnPH0Go3VZbPpryicor7 jfalwDz+7bFKlMhHPFzrd/sBKIp9DfdLiHdKtxYlU3nZwpjEaygtM9X3EXM/T8jHz8X9 ZEuqGYfvTltae6eX0hefG3di94FCHGtFkQs6uUSY8mFOaa6ZQ9AdhAGbUs7PtjIsgAb5 huxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XDDkQeHZ0dijGtSKlhGqjNUEl29/r8+MY+SRNPeDCrg=; b=QyRJHgGNlWTzpDoXTU4DCeldJrNhUpWmnCz5Ri+uyDcP+tqAWY8tqB2Om7L2Dd815e SxiHUOgQaxdndNd+lYWDqdSus09sazpElLteTkfeurQgrWpmJ0vT+kMwBhS9pOX3u0oF Sx//MhiEkRSzGHKUbBd8YOKP1uAiSebD8fADNXZNXBQC+kkeJPgajJkD+fEVotHtYXqO TcBuegGmCbqrxh/H0aj5NAjCNZH+WxMTIlZnutHYvxZQdo/ZTMOQQ2+JGSMFFERrC8u3 RJ6tlUAPdP8HWpKa9RCefS/k9ajQNRZEcg03yeQDA5Cg+YfyFpBLXqO36U6Qow9MigJr 3qMQ== X-Gm-Message-State: AOAM5313w3WPuAOpGcVkYKgeDC2yG/hUM8oVSvNEbB3LqeYiYW8ZCePd /AjJbvDoaNC27DCAQkpXryrbuQ== X-Google-Smtp-Source: ABdhPJzHt8V+FBFCwkJFGAjwVhotNpolupuYxjsEsjXvvCcvmj/IQ0J3+gvAKWOhW/Y8lDqCdW8ezw== X-Received: by 2002:a05:6a00:1a4c:b0:44b:1fa6:532c with SMTP id h12-20020a056a001a4c00b0044b1fa6532cmr5053934pfv.64.1635436662468; Thu, 28 Oct 2021 08:57:42 -0700 (PDT) Received: from [192.168.1.11] (174-21-75-75.tukw.qwest.net. [174.21.75.75]) by smtp.gmail.com with ESMTPSA id 11sm3813499pfl.41.2021.10.28.08.57.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 08:57:42 -0700 (PDT) Subject: Re: [PATCH 13/24] bsd-user/arm/target_arch_thread.h: Routines to create and switch to a thread To: Warner Losh , qemu-devel@nongnu.org References: <20211019164447.16359-1-imp@bsdimp.com> <20211019164447.16359-14-imp@bsdimp.com> From: Richard Henderson Message-ID: Date: Thu, 28 Oct 2021 08:57:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211019164447.16359-14-imp@bsdimp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -48 X-Spam_score: -4.9 X-Spam_bar: ---- X-Spam_report: (-4.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.847, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Klye Evans , Michael Tokarev , Stacey Son , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/19/21 9:44 AM, Warner Losh wrote: > + regs->spsr = ARM_CPU_MODE_USR; > + if (entry & 0x1) { > + regs->spsr |= CPSR_T; > + } (1) Why are you setting SPSR not CPSR? (2) Changes to CPSR cannot be made manually; you need cpsr_write. r~