From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFA8C433C1 for ; Wed, 24 Mar 2021 13:47:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F215261A01 for ; Wed, 24 Mar 2021 13:47:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F215261A01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP3qj-0002qo-Qo for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 09:47:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP3oz-0001tE-3i for qemu-devel@nongnu.org; Wed, 24 Mar 2021 09:45:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP3os-0005A1-An for qemu-devel@nongnu.org; Wed, 24 Mar 2021 09:45:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616593508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNX3cUEJEvvitchZ4JiICyTbhnRmdCtN6N6kmuEXzAQ=; b=DYnyXmCgDb09O5G4cEqSRqOFwrSio/MuKIyBDW4C0zaZHPopiGmU4+c07zIgLLlx6EDSDk gl75RncPbrBsjACn3NcCRtNURCMQk8EzHJXH7EC2YsslKbkWmLnJYVY/ZJ3paCx1TCGkf1 GQ3AwTeLg68nDFFCbCFjLNM1aBWlAmU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-HE81UMOYOLqJrxrnCaT_Rg-1; Wed, 24 Mar 2021 09:45:04 -0400 X-MC-Unique: HE81UMOYOLqJrxrnCaT_Rg-1 Received: by mail-wm1-f71.google.com with SMTP id i14so530509wmq.7 for ; Wed, 24 Mar 2021 06:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sNX3cUEJEvvitchZ4JiICyTbhnRmdCtN6N6kmuEXzAQ=; b=IqhO+9PmNu5RNHaTRaZMX1QqE8qtf7sIEMLmsgtAiSTcGo4ffUDguKM4Rk+zGyt4Li W/ypOR3vvChf57hjZ0ILRvHYXDDukURqxlhOzSWg88S64aEzwffinHKEsQFhwGdxCYeG kzAlxU6ZrQ6YjPpa56L+uOJcNSfun8jJ/VQfkCGeDtpD2nTpXsR+mhEqSoJKWhTPPj+U g6EUIBDRiwyYXC9FDci58LXjazzmGDOZ7Qoa7UhuhVPKBYWRrjI6aW5jyr4CZ6uaYS3w LwF4kA9kiGovTG6jPjjfY0esU4UaMJoNAT/QIZcylQO3NX/puMKbI4I5sd7I3HZeXGiK 692w== X-Gm-Message-State: AOAM533TSm+eQJ/VwSJCZg2k7PeOXDfb5W76UAoWLbHMw3fEG2mxwZhF FcFPo0pHS+F/K5GI5AiGQcd9wVAC2dX5TB4mn9DaSKp9mhTB9Gs39S7H5p1ctsz2M/eHmW2+U7X ASxftH8T6JQmW1sg= X-Received: by 2002:a05:600c:203:: with SMTP id 3mr3013425wmi.88.1616593503473; Wed, 24 Mar 2021 06:45:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdKwGMdMJ6Z7fj8XISovW3Ng8H3ajrRgtYCYoVBSYBWWDKemE3QuKziSl7K0rTjfnDziKVWw== X-Received: by 2002:a05:600c:203:: with SMTP id 3mr3013401wmi.88.1616593503159; Wed, 24 Mar 2021 06:45:03 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e17sm3488513wra.65.2021.03.24.06.45.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 06:45:01 -0700 (PDT) Subject: Re: [PATCH v2] meson: Propagate gnutls dependency to migration To: Jessica Clarke , qemu-devel@nongnu.org References: <20210320164730.33285-1-jrtc27@jrtc27.com> <20210320171221.37437-1-jrtc27@jrtc27.com> From: Paolo Bonzini Message-ID: Date: Wed, 24 Mar 2021 14:45:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210320171221.37437-1-jrtc27@jrtc27.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20/03/21 18:12, Jessica Clarke wrote: > Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this > for softmmu configs, which pull in migration's use of gnutls. > > This fixes the following compilation failure on Arm-based Macs: > > In file included from migration/multifd.c:23: > In file included from migration/tls.h:25: > In file included from include/io/channel-tls.h:26: > In file included from include/crypto/tlssession.h:24: > include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not found > #include > ^~~~~~~~~~~~~~~~~ > 1 error generated. > > (as well as for channel.c and tls.c) > > Signed-off-by: Jessica Clarke > --- > Changes in v2: > * Added error to commit message > > migration/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/meson.build b/migration/meson.build > index 9645f44005..6fa2f8745d 100644 > --- a/migration/meson.build > +++ b/migration/meson.build > @@ -24,7 +24,7 @@ softmmu_ss.add(files( > 'savevm.c', > 'socket.c', > 'tls.c', > -)) > +), gnutls) > > softmmu_ss.add(when: ['CONFIG_RDMA', rdma], if_true: files('rdma.c')) > softmmu_ss.add(when: 'CONFIG_LIVE_BLOCK_MIGRATION', if_true: files('block.c')) > Queued, thanks. Paolo