From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D445C49ED7 for ; Fri, 13 Sep 2019 12:48:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64F4220830 for ; Fri, 13 Sep 2019 12:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64F4220830 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8kzl-00022D-2A for qemu-devel@archiver.kernel.org; Fri, 13 Sep 2019 08:48:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57718) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8kyo-0001Xr-H9 for qemu-devel@nongnu.org; Fri, 13 Sep 2019 08:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8kyn-0002c1-GS for qemu-devel@nongnu.org; Fri, 13 Sep 2019 08:47:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36206) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8kyk-0002ZO-A6; Fri, 13 Sep 2019 08:47:10 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 559052D6E4F; Fri, 13 Sep 2019 12:47:09 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-116-81.ams2.redhat.com [10.36.116.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 751F219C78; Fri, 13 Sep 2019 12:47:07 +0000 (UTC) To: John Snow , qemu-block@nongnu.org References: <20190819201851.24418-1-mreitz@redhat.com> <20190819201851.24418-7-mreitz@redhat.com> <44f97011-4a02-7832-c253-d43474f79d44@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Fri, 13 Sep 2019 14:47:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <44f97011-4a02-7832-c253-d43474f79d44@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zGmX5d0LCvazSbMSFBKglHW5ZbOlN88rE" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 13 Sep 2019 12:47:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zGmX5d0LCvazSbMSFBKglHW5ZbOlN88rE Content-Type: multipart/mixed; boundary="5SKXxCPflGojLL608oZxhQ9BUiAnFEGcK"; protected-headers="v1" From: Max Reitz To: John Snow , qemu-block@nongnu.org Cc: Kevin Wolf , Thomas Huth , qemu-devel@nongnu.org Message-ID: Subject: Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093 References: <20190819201851.24418-1-mreitz@redhat.com> <20190819201851.24418-7-mreitz@redhat.com> <44f97011-4a02-7832-c253-d43474f79d44@redhat.com> In-Reply-To: <44f97011-4a02-7832-c253-d43474f79d44@redhat.com> --5SKXxCPflGojLL608oZxhQ9BUiAnFEGcK Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 20.08.19 23:32, John Snow wrote: >=20 >=20 > On 8/19/19 4:18 PM, Max Reitz wrote: >> null-aio may not be whitelisted. Skip all test cases that require it.= >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/093 | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093 >> index 50c1e7f2ec..f03fa24a07 100755 >> --- a/tests/qemu-iotests/093 >> +++ b/tests/qemu-iotests/093 >> @@ -24,7 +24,7 @@ import iotests >> nsec_per_sec =3D 1000000000 >> =20 >> class ThrottleTestCase(iotests.QMPTestCase): >> - test_img =3D "null-aio://" >> + test_driver =3D "null-aio" >> max_drives =3D 3 >> =20 >> def blockstats(self, device): >> @@ -35,10 +35,14 @@ class ThrottleTestCase(iotests.QMPTestCase): >> return stat['rd_bytes'], stat['rd_operations'], stat[= 'wr_bytes'], stat['wr_operations'] >> raise Exception("Device not found for blockstats: %s" % devic= e) >> =20 >> + def required_drivers(self): >> + return [self.test_driver] >> + >> + @iotests.skip_if_unsupported(required_drivers) >=20 > Oh, I see why you're passing args[0] back to the callback now. Why not > just pass self.required_drivers and call it with no arguments instead? >=20 > You can get a bound version that way that doesn't need additional > arguments, and then the callback is free to take generic callables of > any kind. Am I doing something wrong? I just get +Traceback (most recent call last): + File "093", line 26, in + class ThrottleTestCase(iotests.QMPTestCase): + File "093", line 41, in ThrottleTestCase + @iotests.skip_if_unsupported(self.required_drivers) +NameError: name 'self' is not defined this way. Max --5SKXxCPflGojLL608oZxhQ9BUiAnFEGcK-- --zGmX5d0LCvazSbMSFBKglHW5ZbOlN88rE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl17j8kACgkQ9AfbAGHV z0ADYQf/UEETol4Gl/n/6rJWlCe408wpTgAQZc5jjAlTpxeAsT/06WNsZQukW3V4 8kibc+JJN8/uLe9oaUtGCmV6Ymgk/Vtqv71JeVSWKAa1V8r0jKOk020K44eX5Tin GT5n/m6LJXBQLHFOiZDPgrRvPP2sNSAuLaqux304raQvCi06v7XvRekiEyaFmHoZ Yf2w/fAHsupazlmCbyhYH90o/fsVG0Cmhie1xL4qCaCLzCVk7TtYKlCzaek9Odxw tJGD++pM+yhNdxbjDhrYzN+FzVaaiIrVgqC2dHLyRxl3L5MWRit9iQqLHY7AhiDT YDMHyaLiacBCYDj9vH9xgIo+pCnXwA== =2liB -----END PGP SIGNATURE----- --zGmX5d0LCvazSbMSFBKglHW5ZbOlN88rE--