From: Richard Henderson <richard.henderson@linaro.org>
To: Rebecca Cran <rebecca@nuviainc.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into env->pstate
Date: Wed, 3 Feb 2021 07:19:20 -1000 [thread overview]
Message-ID: <a85fa6f0-d6ee-5811-4c7f-d2830b8eafb9@linaro.org> (raw)
In-Reply-To: <20210203045816.10953-3-rebecca@nuviainc.com>
On 2/2/21 6:58 PM, Rebecca Cran wrote:
> @@ -9433,8 +9448,9 @@ static void take_aarch32_exception(CPUARMState *env, int new_mode,
> * For exceptions taken to AArch32 we must clear the SS bit in both
> * PSTATE and in the old-state value we save to SPSR_<mode>, so zero it now.
> */
> - env->uncached_cpsr &= ~PSTATE_SS;
> - env->spsr = cpsr_read(env);
> + env->pstate &= ~PSTATE_SS;
> + env->spsr = cpsr_read_for_spsr_elx(env);
> +
Again, this is the aarch32 exception path, and should not use
cpsr_read_for_spsr_elx.
r~
next prev parent reply other threads:[~2021-02-03 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 4:58 [PATCH v4 0/4] target/arm: Add support for FEAT_DIT, Data Independent Timing Rebecca Cran
2021-02-03 4:58 ` [PATCH v4 1/4] " Rebecca Cran
2021-02-03 4:58 ` [PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into env->pstate Rebecca Cran
2021-02-03 17:17 ` Richard Henderson
2021-02-03 20:28 ` Rebecca Cran
2021-02-03 20:36 ` Richard Henderson
2021-02-03 17:19 ` Richard Henderson [this message]
2021-02-08 6:50 ` Rebecca Cran
2021-02-03 4:58 ` [PATCH v4 3/4] target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU Rebecca Cran
2021-02-03 4:58 ` [PATCH v4 4/4] target/arm: Set ID_PFR0.DIT to 1 for "max" 32-bit CPU Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85fa6f0-d6ee-5811-4c7f-d2830b8eafb9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rebecca@nuviainc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).