From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B12EC433F5 for ; Sun, 12 Sep 2021 22:17:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E59060FE3 for ; Sun, 12 Sep 2021 22:17:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E59060FE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPXnQ-0001uU-UR for qemu-devel@archiver.kernel.org; Sun, 12 Sep 2021 18:17:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPXmd-0001G9-21 for qemu-devel@nongnu.org; Sun, 12 Sep 2021 18:17:07 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:36825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPXmb-0002e2-Ey for qemu-devel@nongnu.org; Sun, 12 Sep 2021 18:17:06 -0400 Received: by mail-pf1-x436.google.com with SMTP id m26so7066597pff.3 for ; Sun, 12 Sep 2021 15:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XhCmaQMkmisXWKGWNs9jfRMRQSyGUb6gFOzy0UNRmMA=; b=o4ds6JoC6Iy0jUj5GkecLPKxtdwBDDbf9PpjNMwKcPe1MrWqtE+DhdmE1g4/SaSfic 7EZwwWwfUMNFoUbHS/bgl/xyKV5BRAFJAkVlqKWW38kvbufFke5TEkzH8JWb2yi2fKFb gFtnngeLMKkVSdYt6e085JYSf9VxNznOmgQFEVTNLCIO47TZHCSYMLeEPrtvF/TVad4+ SxeDElDu082OP2hUKgER7UddwFuexX5LtYIH856uBnYaGaEOGRZvlpqIbD4+3H4ElVoR suu3VAvssw2fqkd6SM/1OB2Z20cfq+x02hy4Ql9jZG6mEYaJSU8UTjetOvSVtCNGU7Yt IkgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XhCmaQMkmisXWKGWNs9jfRMRQSyGUb6gFOzy0UNRmMA=; b=0POdHTB2K9qRrOAYTvxNrchgthAQuVmqKwrFJSkX6dJ+l9VLxbyslQw44Pafpsw4ES ot563Ig+GmpC4Ly07sR4IR1urLbVV5HjEEdvfutpbeDRPHNG892LxeoGkxqSSeS5XAcP CpcQskOPUbEfpjNxUgfTZIwSxAYxcbAkfKiuKYK1pB8HgSGg+Br8zq+dzZ/SJYoCHRaC OGIDaEEC7AyaCPtrPEBJzoIuXktdocQtjS0Dbr9HLlIFkA6LIKfSb0IbViE5ImmC8GU8 R1bS0Mf7QkQ8Q767xzhpKgKEBTeEmxGomqghEK93mtP2KqmpudXOFdUitl8IDlrRyU1h U8NQ== X-Gm-Message-State: AOAM530PumX+kIu16QCKw5aca76rnE6PKn7gwPvsLSNZNeaXPUZ+Y2vD 9QL/CCpNabzS+8N97AVRbXOCtg== X-Google-Smtp-Source: ABdhPJzDNYaj4c7GVig+MNyB8C5VK1tKJu7jeQ7iUt3gOHQxzeVrzEdXiFJTWpG0d35t13kdTmlpiQ== X-Received: by 2002:a63:af18:: with SMTP id w24mr8368521pge.471.1631485023111; Sun, 12 Sep 2021 15:17:03 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id z9sm4686681pfn.22.2021.09.12.15.17.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 15:17:02 -0700 (PDT) Subject: Re: [PATCH v2] accel/tcg/user-exec: Fix read-modify-write of code on s390 hosts To: Ilya Leoshkevich , Riku Voipio , Paolo Bonzini References: <20210803221606.150103-1-iii@linux.ibm.com> From: Richard Henderson Message-ID: Date: Sun, 12 Sep 2021 15:17:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210803221606.150103-1-iii@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.584, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-devel@nongnu.org, Andreas Krebbel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/3/21 3:16 PM, Ilya Leoshkevich wrote: > x86_64 dotnet/runtime uses cmpxchg for code patching. When running it > under s390x qemu-linux user, cpu_signal_handler() does not recognize > this as a write and does not restore PAGE_WRITE cleared by > tb_page_add(), incorrectly forwarding the signal to the guest code. > > Signed-off-by: Ilya Leoshkevich > --- > > v1:https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg00464.html > v1 -> v2: Fix comment style, fix CSST detection (Richard). > > accel/tcg/user-exec.c | 48 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 41 insertions(+), 7 deletions(-) Queued, thanks. r~