From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FE0C433B4 for ; Tue, 27 Apr 2021 11:02:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF2AC613B4 for ; Tue, 27 Apr 2021 11:02:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF2AC613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbLUT-00010d-FJ for qemu-devel@archiver.kernel.org; Tue, 27 Apr 2021 07:02:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbLSh-0008DZ-7C; Tue, 27 Apr 2021 07:01:03 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:2740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbLSZ-0008MZ-CW; Tue, 27 Apr 2021 07:01:03 -0400 Received: from dggeml763-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FTzGn2jc7z19HdN; Tue, 27 Apr 2021 18:56:49 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggeml763-chm.china.huawei.com (10.1.199.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 27 Apr 2021 19:00:44 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 27 Apr 2021 19:00:43 +0800 Subject: Re: [RFC PATCH 0/6] Introduce cluster cpu topology support To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , , References: <20210331095343.12172-1-wangyanan55@huawei.com> <13983bec-8b6b-4277-288a-e243d096bfb3@redhat.com> From: "wangyanan (Y)" Message-ID: Date: Tue, 27 Apr 2021 19:00:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <13983bec-8b6b-4277-288a-e243d096bfb3@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme711-chm.china.huawei.com (10.1.199.107) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.255; envelope-from=wangyanan55@huawei.com; helo=szxga08-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Peter Maydell , Andrew Jones , Eduardo Habkost , "Michael S . Tsirkin" , Richard Henderson , Shannon Zhao , Igor Mammedov , Paolo Bonzini , yuzenghui@huawei.com, wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, Jiajie Li Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Philippe, On 2021/4/27 17:57, Philippe Mathieu-Daudé wrote: > Hi Yanan, > > On 3/31/21 11:53 AM, Yanan Wang wrote: >> Hi, >> This series introduces the cluster cpu topology support, besides now >> existing sockets, cores, and threads. >> >> A cluster means a group of cores that share some resources (e.g. cache) >> among them under the LLC. For example, ARM64 server chip Kunpeng 920 has >> 6 or 8 clusters in each NUMA, and each cluster has 4 cores. All clusters >> share L3 cache data while cores within each cluster share the L2 cache. >> >> Also, there are some x86 CPU implementations (e.g. Jacobsville) where L2 >> cache is shared among a cluster of cores instead of being exclusive to >> one single core. For example, on Jacobsville there are 6 clusters of 4 >> Atom cores, each cluster sharing a separate L2, and 24 cores sharing L3). >> About this series: >> Note that, this series was implemented based on [3] and [4]. Although they >> have not merged into qemu mainline for now, it's still meaning to post this >> series to express the thoughts first. So a RFC is sent and any comments are >> welcomed and appreciated. > At a glance: tests/unit/test-x86-cpuid.c should be adapted to be generic > (but still supporting target-specific sub-tests) and some aarch64 tests > added. > > Similarly the ARM PPTT tables tested in tests/qtest/bios-tables-test.c. > > Otherwise, the overall series looks good and coherent, but it isn't my > area :) Thank you for the reminder of the related tests. :) I will have some work to make them cover the new features introduced by this series. Thanks, Yanan > > Regards, > > Phil. > > .