From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()
Date: Fri, 26 Mar 2021 19:49:02 +0100 [thread overview]
Message-ID: <aafa7c42-333e-60ce-1323-5623536d7af8@amsat.org> (raw)
In-Reply-To: <CAFEAcA9hz5ZsetCWMGJd+aX0td6vE7YiAW+x2C=K3mCsdWiJ8w@mail.gmail.com>
On 3/26/21 2:34 PM, Peter Maydell wrote:
> ping for review?
FYI:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html
> On Fri, 19 Mar 2021 at 16:24, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> In commit 81b3ddaf8772ec we fixed a use of uninitialized data
>> in read_tcnt(). However this change wasn't enough to placate
>> Coverity, which is not smart enough to see that if we read a
>> 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot
>> be a flow of execution through the switch default. Add explicit
>> default cases which assert that they can't be reached, which
>> should help silence Coverity.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> hw/timer/renesas_tmr.c | 4 ++++
>> 1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-03-26 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 16:24 [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt() Peter Maydell
2021-03-26 13:34 ` Peter Maydell
2021-03-26 18:49 ` Philippe Mathieu-Daudé [this message]
2021-03-29 17:03 ` Philippe Mathieu-Daudé
2021-03-29 17:55 ` Peter Maydell
2021-04-01 15:58 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aafa7c42-333e-60ce-1323-5623536d7af8@amsat.org \
--to=f4bug@amsat.org \
--cc=magnus.damm@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).