From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163DDC43461 for ; Wed, 12 May 2021 14:53:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40B6761425 for ; Wed, 12 May 2021 14:53:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40B6761425 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgqFA-0007KF-Qp for qemu-devel@archiver.kernel.org; Wed, 12 May 2021 10:53:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgqDU-0005Fi-6v for qemu-devel@nongnu.org; Wed, 12 May 2021 10:52:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgqDR-0000ra-2k for qemu-devel@nongnu.org; Wed, 12 May 2021 10:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620831119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WiytFHp9GTlPpbOlUbra7OApVRFckmBqgKStxbz+M3A=; b=Yf/oDbF97+5JFQYclRVyA4QStaDqUfCgBLuDDcB/rDvgv7bvjyQPRriOBXPAyMQDpFnPDG nopLSJJrGa5Uy97ShAuJEKEEMD2hthc9LUcF6R/PDVGFdLH3drUjQo9BjI3wvKmHwBnA3t IedXNlEMsh6bez6bHtb7+Erdy+x1kdI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-zYpNEOfwNL6sCHh3QZsPug-1; Wed, 12 May 2021 10:51:56 -0400 X-MC-Unique: zYpNEOfwNL6sCHh3QZsPug-1 Received: by mail-wm1-f69.google.com with SMTP id g206-20020a1c39d70000b029016ac627fbe9so903980wma.9 for ; Wed, 12 May 2021 07:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WiytFHp9GTlPpbOlUbra7OApVRFckmBqgKStxbz+M3A=; b=gBNeW/ZNUnxDhbTA5MD3DIgLkleO9ruGCLKoG7tLudQJKJ65v1E9zjRPA1HpTMRqqB RofBj+Xy1nnCGI+Xfhazohr7ZAS4+rRtx0lK+TOPZQy1hPEpdgY3nWKiC87pOop8q7Vj Xssx7LJSjHyIb8jvXUOBaaeerNpMvVmFZZmxjhQfH0Gk13KpuabBJ+E0dqLbzoRz1h/E xUF667S1Bjm2q7f8nLJUsdonL47MTvSKVCcOI8UVV07lFXXcbK1Ov1aWZ7C4RikiWmnr ChreDkHCK4VDZW3xBa3rYjv1SkG3vxrrMGHfwk3fTQO9pqj4WQ8xugKL5Xl/fdfWH6W2 T/2w== X-Gm-Message-State: AOAM53283LVoxBPSde3qwrXinUuvHZgs3kJ4W9N4LeOHzwJ5p7LagR7w 5nMqBTm2l1d/rdEe0Nj8IXZJHqGQ3Z7HRwinfZCrdJtckB3hUc8AmloRRqj4IsHJ+RWvAXh5szb zIYwl+3ty2KiFe00= X-Received: by 2002:a05:600c:4f48:: with SMTP id m8mr11809804wmq.169.1620831115160; Wed, 12 May 2021 07:51:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvEBzHkqzwmKi72+436P0Ni1w+hnHSc2tw3vIDmdCO/XLqub1jClaaKFD/m1Tw0JAgjj2DOw== X-Received: by 2002:a05:600c:4f48:: with SMTP id m8mr11809776wmq.169.1620831114842; Wed, 12 May 2021 07:51:54 -0700 (PDT) Received: from thuth.remote.csb (pd9e832bb.dip0.t-ipconnect.de. [217.232.50.187]) by smtp.gmail.com with ESMTPSA id v12sm1324389wrv.76.2021.05.12.07.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 May 2021 07:51:54 -0700 (PDT) Subject: Re: [PULL 8/9] pc-bios/s390-ccw: Allow building with Clang, too From: Thomas Huth To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Peter Maydell References: <20210510073524.85951-1-thuth@redhat.com> <20210510073524.85951-9-thuth@redhat.com> <0b9763cb-f593-011a-0ca8-467c74c04069@redhat.com> <8bfa8629-93dd-5665-1dfd-c26c74ee8cfb@redhat.com> Message-ID: Date: Wed, 12 May 2021 16:51:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <8bfa8629-93dd-5665-1dfd-c26c74ee8cfb@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , cohuck@redhat.com, Richard Henderson , Christian Borntraeger , qemu-s390x@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/05/2021 16.00, Thomas Huth wrote: > On 12/05/2021 15.40, Thomas Huth wrote: >> On 12/05/2021 13.53, Philippe Mathieu-Daudé wrote: >>> On 5/10/21 9:35 AM, Thomas Huth wrote: >>>> Clang unfortunately does not support generating code for the z900 >>>> architecture level and starts with the z10 instead. Thus to be able >>>> to support compiling with Clang, we have to check for the supported >>>> compiler flags. The disadvantage is of course that the bios image >>>> will only run with z10 guest CPUs upwards (which is what most people >>>> use anyway), so just in case let's also emit a warning in that case >>>> (we will continue to ship firmware images that have been pre-built >>>> with GCC in future releases, so this should not impact normal users, >>>> too). >>>> >>>> Message-Id: <20210502174836.838816-5-thuth@redhat.com> >>>> Reviewed-by: Philippe Mathieu-Daudé >>>> Reviewed-by: Cornelia Huck >>>> Signed-off-by: Thomas Huth >>>> --- >>>>   configure                 | 9 ++++++++- >>>>   pc-bios/s390-ccw/Makefile | 3 ++- >>>>   2 files changed, 10 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/configure b/configure >>>> index 4f374b4889..5ebc937746 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -5417,9 +5417,16 @@ if { test "$cpu" = "i386" || test "$cpu" = >>>> "x86_64"; } && \ >>>>   fi >>>>   # Only build s390-ccw bios if we're on s390x and the compiler has >>>> -march=z900 >>>> +# or -march=z10 (which is the lowest architecture level that Clang >>>> supports) >>>>   if test "$cpu" = "s390x" ; then >>>>     write_c_skeleton >>>> -  if compile_prog "-march=z900" ""; then >>>> +  compile_prog "-march=z900" "" >>>> +  has_z900=$? >>>> +  if [ $has_z900 = 0 ] || compile_prog "-march=z10" ""; then >>>> +    if [ $has_z900 != 0 ]; then >>>> +      echo "WARNING: Your compiler does not support the z900!" >>>> +      echo "         The s390-ccw bios will only work with guest CPUs >>>> >= z10." >>>> +    fi >>>>       roms="$roms s390-ccw" >>>>       # SLOF is required for building the s390-ccw firmware on s390x, >>>>       # since it is using the libnet code from SLOF for network booting. >>>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile >>>> index 83fb1afb73..cee9d2c63b 100644 >>>> --- a/pc-bios/s390-ccw/Makefile >>>> +++ b/pc-bios/s390-ccw/Makefile >>>> @@ -34,7 +34,8 @@ QEMU_CFLAGS += $(call cc-option,-Werror >>>> $(QEMU_CFLAGS),-Wno-stringop-overflow) >>>>   QEMU_CFLAGS += -ffreestanding -fno-delete-null-pointer-checks >>>> -fno-common -fPIE >>>>   QEMU_CFLAGS += -fwrapv -fno-strict-aliasing >>>> -fno-asynchronous-unwind-tables >>>>   QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS), -fno-stack-protector) >>>> -QEMU_CFLAGS += -msoft-float -march=z900 >>>> +QEMU_CFLAGS += -msoft-float >>>> +QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS),-march=z900,-march=z10) >>>>   QEMU_CFLAGS += -std=gnu99 >>>>   LDFLAGS += -Wl,-pie -nostdlib >>> >>> This broke the travis-ci  "[s390x] Clang (disable-tcg)" job: >>> https://travis-ci.org/github/qemu/qemu/jobs/770794417#L1776 >>> >>> Description:    Ubuntu 18.04.4 LTS >>> Release:    18.04 >>> Codename:    bionic >>> >>> $ clang --version >>> clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) >>> Target: s390x-ibm-linux-gnu >> >> Darn! ... I guess we should switch to the clang-10 package which should be >> available there, since Daniel also plans to raise the minimum Clang >> version to 7.0 now ... I'll try to come up with a patch... > > Never mind to update travis.yml ... I just read: > > https://blog.travis-ci.com/2021-05-07-orgshutdown > > i.e. travis-ci.org will be finally really be shut down at the end of the > month. We should remove our travis-ci.yml file now. Never mind the never mind ... as I just learnt, Travis now offers free CI again for s390x and aarch64, so we certainly should not remove the travis-ci.yml file yet. Thomas