From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2402C433B4 for ; Thu, 8 Apr 2021 13:25:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E71261107 for ; Thu, 8 Apr 2021 13:25:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E71261107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUUfE-0003gR-9b for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 09:25:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUUe3-0002J3-Es for qemu-devel@nongnu.org; Thu, 08 Apr 2021 09:24:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:60832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUUe0-0002zW-NH for qemu-devel@nongnu.org; Thu, 08 Apr 2021 09:24:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0341AB090; Thu, 8 Apr 2021 13:24:23 +0000 (UTC) Subject: Re: [RFC v12 40/65] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM To: Richard Henderson , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-41-cfontana@suse.de> <4d052899-9645-d98b-50d2-17d91271bc39@suse.de> From: Claudio Fontana Message-ID: Date: Thu, 8 Apr 2021 15:24:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/29/21 4:03 PM, Richard Henderson wrote: > On 3/29/21 1:02 AM, Claudio Fontana wrote: >> On 3/28/21 7:21 PM, Richard Henderson wrote: >>> On 3/26/21 1:36 PM, Claudio Fontana wrote: >>>> test is TCG-only. >>>> >>>> Signed-off-by: Claudio Fontana >>>> Cc: Philippe Mathieu-Daudé >>>> --- >>>> tests/qtest/bios-tables-test.c | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c >>>> index e020c83d2a..bd7b85909c 100644 >>>> --- a/tests/qtest/bios-tables-test.c >>>> +++ b/tests/qtest/bios-tables-test.c >>>> @@ -1488,6 +1488,13 @@ static void test_acpi_oem_fields_virt(void) >>>> }; >>>> char *args; >>>> >>>> +#ifndef CONFIG_TCG >>>> + if (data.tcg_only) { >>>> + g_test_skip("TCG disabled, skipping ACPI tcg_only test"); >>>> + return; >>>> + } >>>> +#endif /* CONFIG_TCG */ >>> >>> Why is this an ifdef and not tcg_enabled()? >> >> We want to launch this whenever TCG is compiled in. >> >>> We're using kvm_enabled() elsewhere... >> >> where? > > Whoops, there's a local re-definition of the function at the top of > tests/qtest/arm-cpu-features.c. Hmm. > > r~ > Indeed, an unfortunate name clash.