From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [PATCH v3 0/6] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs
Date: Tue, 4 May 2021 22:30:43 +0100 [thread overview]
Message-ID: <abe0c759-23d3-5341-2a0e-4af47a5567d3@ilande.co.uk> (raw)
In-Reply-To: <20210503171303.822501-1-f4bug@amsat.org>
On 03/05/2021 18:12, Philippe Mathieu-Daudé wrote:
> Missing review: 6
>
> Hi Mark,
>
> This series QOM'ify the sun4m machines.
> I need it for a further memory maxsize check.
> It is mostly code movement (and the diff-stat is good).
>
> Since v2:
> - use static const variable for hwdef (Richard)
> - added Richard's R-b tag
>
> Since v1:
> - Full rewrite after Mark review
>
> Philippe Mathieu-Daudé (6):
> hw/sparc/sun4m: Have sun4m machines inherit new TYPE_SUN4M_MACHINE
> hw/sparc/sun4m: Introduce Sun4mMachineClass
> hw/sparc/sun4m: Factor out sun4m_machine_class_init()
> hw/sparc/sun4m: Register machine types in sun4m_machine_types[]
> hw/sparc/sun4m: Fix code style for checkpatch.pl
> hw/sparc/sun4m: Move each sun4m_hwdef definition in its class_init
>
> hw/sparc/sun4m.c | 459 +++++++++++++++++++----------------------------
> 1 file changed, 186 insertions(+), 273 deletions(-)
Looks good to me:
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
I've also queued this to my qemu-sparc branch.
ATB,
Mark.
prev parent reply other threads:[~2021-05-04 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 17:12 [PATCH v3 0/6] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs Philippe Mathieu-Daudé
2021-05-03 17:12 ` [PATCH v3 1/6] hw/sparc/sun4m: Have sun4m machines inherit new TYPE_SUN4M_MACHINE Philippe Mathieu-Daudé
2021-05-03 17:12 ` [PATCH v3 2/6] hw/sparc/sun4m: Introduce Sun4mMachineClass Philippe Mathieu-Daudé
2021-05-03 17:13 ` [PATCH v3 3/6] hw/sparc/sun4m: Factor out sun4m_machine_class_init() Philippe Mathieu-Daudé
2021-05-03 17:13 ` [PATCH v3 4/6] hw/sparc/sun4m: Register machine types in sun4m_machine_types[] Philippe Mathieu-Daudé
2021-05-03 17:13 ` [PATCH v3 5/6] hw/sparc/sun4m: Fix code style for checkpatch.pl Philippe Mathieu-Daudé
2021-05-03 17:13 ` [PATCH v3 6/6] hw/sparc/sun4m: Move each sun4m_hwdef definition in its class_init Philippe Mathieu-Daudé
2021-05-03 19:22 ` Richard Henderson
2021-05-04 21:30 ` Mark Cave-Ayland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe0c759-23d3-5341-2a0e-4af47a5567d3@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=atar4qemu@gmail.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).