From: "Cédric Le Goater" <clg@kaod.org>
To: <matheus.ferst@eldorado.org.br>, <qemu-devel@nongnu.org>,
<qemu-ppc@nongnu.org>
Cc: danielhb413@gmail.com,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
groug@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH] target/ppc: Fix register update on lf[sd]u[x]/stf[sd]u[x]
Date: Wed, 10 Nov 2021 09:04:36 +0100 [thread overview]
Message-ID: <ae379705-5697-4a03-df04-3d20799f7d83@kaod.org> (raw)
In-Reply-To: <20211109192911.485507-1-matheus.ferst@eldorado.org.br>
On 11/9/21 20:29, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> These instructions should update the GPR indicated by the field RA
> instead of RT. This error caused a regression on Mac OS 9 boot and some
> graphical glitches in OS X.
I could reproduce the issue and the fix on Mac OS 9. I wonder how we could
automate the MacOS tests since they are graphical.
> Fixes: a39a106634a9 ("target/ppc: Move load and store floating point instructions to decodetree")
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> ---
> target/ppc/translate/fp-impl.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied for 6.2
Thanks,
C.
>
> diff --git a/target/ppc/translate/fp-impl.c.inc b/target/ppc/translate/fp-impl.c.inc
> index d1dbb1b96b..c9e05201d9 100644
> --- a/target/ppc/translate/fp-impl.c.inc
> +++ b/target/ppc/translate/fp-impl.c.inc
> @@ -1328,7 +1328,7 @@ static bool do_lsfpsd(DisasContext *ctx, int rt, int ra, TCGv displ,
> set_fpr(rt, t0);
> }
> if (update) {
> - tcg_gen_mov_tl(cpu_gpr[rt], ea);
> + tcg_gen_mov_tl(cpu_gpr[ra], ea);
> }
> tcg_temp_free_i64(t0);
> tcg_temp_free(ea);
>
prev parent reply other threads:[~2021-11-10 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 19:29 [PATCH] target/ppc: Fix register update on lf[sd]u[x]/stf[sd]u[x] matheus.ferst
2021-11-10 8:04 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae379705-5697-4a03-df04-3d20799f7d83@kaod.org \
--to=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).