From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD65C433DB for ; Mon, 29 Mar 2021 07:00:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CC626195E for ; Mon, 29 Mar 2021 07:00:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CC626195E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQlsc-0001xk-1r for qemu-devel@archiver.kernel.org; Mon, 29 Mar 2021 03:00:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQlrL-0001Uq-4u for qemu-devel@nongnu.org; Mon, 29 Mar 2021 02:58:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:41632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQlrI-00020E-Tu for qemu-devel@nongnu.org; Mon, 29 Mar 2021 02:58:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DAA55B025; Mon, 29 Mar 2021 06:58:40 +0000 (UTC) Subject: Re: [RFC v12 38/65] target/arm: remove broad "else" statements when checking accels To: Richard Henderson , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-39-cfontana@suse.de> <00984c12-4861-7234-d62c-3a8a84ad5e31@linaro.org> From: Claudio Fontana Message-ID: Date: Mon, 29 Mar 2021 08:58:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <00984c12-4861-7234-d62c-3a8a84ad5e31@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Eduardo Habkost , Julien Grall , qemu-devel@nongnu.org, Olaf Hering , Roman Bolshakov , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/28/21 7:11 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> @@ -638,24 +638,21 @@ static int cpu_pre_save(void *opaque) >> >> if (tcg_enabled()) { >> pmu_op_start(&cpu->env); >> + if (!write_cpustate_to_list(cpu, false)) { >> + /* This should never fail. */ >> + abort(); >> + } >> } >> - >> if (kvm_enabled()) { >> if (!write_kvmstate_to_list(cpu)) { >> /* This should never fail */ >> abort(); >> } >> - >> /* >> * kvm_arm_cpu_pre_save() must be called after >> * write_kvmstate_to_list() >> */ >> kvm_arm_cpu_pre_save(cpu); >> - } else { >> - if (!write_cpustate_to_list(cpu, false)) { >> - /* This should never fail. */ >> - abort(); >> - } >> } > > Hmm. Not perfect. I can't decide on > > if (tcg) { > ... > } else if (kvm) { > ... > } > this is fine for me, > or > > if (tcg) { > pmu > } > if (kvm || tcg) { > write_cpustate_to_list > } > if (kvm) { > rest of kvm stuff > } > this is incorrect, so the choice is easy, lets do the first. Thanks, Claudio > > r~ >