From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106BBC49EA6 for ; Thu, 24 Jun 2021 07:44:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C855A61185 for ; Thu, 24 Jun 2021 07:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C855A61185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwK2G-0000UP-Uh for qemu-devel@archiver.kernel.org; Thu, 24 Jun 2021 03:44:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwK0y-0006uv-9v for qemu-devel@nongnu.org; Thu, 24 Jun 2021 03:43:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwK0w-0002Ys-FD for qemu-devel@nongnu.org; Thu, 24 Jun 2021 03:43:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624520585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7sPThbQ0+nPD0kwk/krXdGTpnNcdOiuJugIOoSsIK0=; b=b3U4mpdgiHmcNbbuki5n3V8wBw1ekUUIxJ+tzs++R4BqWlnAP024bIq6D+n2ZFFCQQYXVW g4qwoplc4uiekg8rUfb5CvD6D+rKfk+QRTJDKqZ7POutY0jS5tILwLgKP+BNPqd0k6Yiv2 Ut4vMhXEpbQb4XRcdRgEShEwCR8i1wE= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-Opn7-K_wPEq_EadWTIh2zg-1; Thu, 24 Jun 2021 03:43:04 -0400 X-MC-Unique: Opn7-K_wPEq_EadWTIh2zg-1 Received: by mail-pl1-f198.google.com with SMTP id g16-20020a1709028690b029011e9e164a59so1903357plo.23 for ; Thu, 24 Jun 2021 00:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=D7sPThbQ0+nPD0kwk/krXdGTpnNcdOiuJugIOoSsIK0=; b=uBQTGWf00pj6fC8bmZPeWex2TG6gowbHV7Zz6QiNP9Q3s132X6Qqdhj+sV9AdCkcgj wnX0G/hVvR3g/70L0C0x754xicZIQyZCav6+yR/QpCHV4CxxBMJRu1PehHzLLGC4GLTS 8T84qux9IlrE0OwxYJ6M3V6pXs3nlb3lNFvj6SNKW549OtAF3foEGQNfJ0YwJLPvhbgt uSezVWNmgNF+JWyzglVKy9PocaUWaYRUIE/b+Q/H3KMKTHhMScTo/YJWb4THLPqjq0tc f/YbLQW32aekr8Sn80RlpKen8kb+/9QhAJ3CBxqkjwh44sk3gYb1lca2pKORDUh6ihKx yPYQ== X-Gm-Message-State: AOAM531yyh2n2jR+e18Qg6jc/TmNRevRwutoS+qNPiC20l4RC2OOaoEe biA1iiEFN9j0ZKUk5aMW3wlxTw0ibDqDkijv1zL9GiqnCfaTWumo2l39kGeQPE1kmqSM1keaOi0 35Xg+jgzZxQ0est8= X-Received: by 2002:aa7:8186:0:b029:2f7:f70a:b7be with SMTP id g6-20020aa781860000b02902f7f70ab7bemr3870395pfi.64.1624520583159; Thu, 24 Jun 2021 00:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtUNoeY2vvZcwXzE810k0mxJrIQsZ86TszShCPvsc8fMcSJyPn8rJa5rXzL1MzFqbnVtb6Aw== X-Received: by 2002:aa7:8186:0:b029:2f7:f70a:b7be with SMTP id g6-20020aa781860000b02902f7f70ab7bemr3870383pfi.64.1624520582992; Thu, 24 Jun 2021 00:43:02 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id n5sm1499144pgf.35.2021.06.24.00.43.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 00:43:02 -0700 (PDT) Subject: Re: [PATCH 01/18] vhost_net: remove the meaningless assignment in vhost_net_start_one() To: Eli Cohen References: <20210621041650.5826-1-jasowang@redhat.com> <20210621041650.5826-2-jasowang@redhat.com> <20210621114506.GA143139@mtl-vdi-166.wap.labs.mlnx> From: Jason Wang Message-ID: Date: Thu, 24 Jun 2021 15:42:58 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210621114506.GA143139@mtl-vdi-166.wap.labs.mlnx> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.373, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_CHARSET_FARAWAY=2.45, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eperezma@redhat.com, lingshan.zhu@intel.com, qemu-devel@nongnu.org, lulu@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" ÔÚ 2021/6/21 ÏÂÎç7:45, Eli Cohen дµÀ: > On Mon, Jun 21, 2021 at 12:16:33PM +0800, Jason Wang wrote: >> The nvqs and vqs has been initialized during vhost_net_init() and is > I suggest "nvqs and vqs have been initialized during vhost_net_init() and > are not..." > Other than that > Reviewed-by: Eli Cohen Will fix. Thanks > >> not expected to change during the life cycle of vhost_net >> structure. So this patch removes the meaningless assignment. >> >> Signed-off-by: Jason Wang >> --- >> hw/net/vhost_net.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c >> index 44c1ed92dc..6bd4184f96 100644 >> --- a/hw/net/vhost_net.c >> +++ b/hw/net/vhost_net.c >> @@ -238,9 +238,6 @@ static int vhost_net_start_one(struct vhost_net *net, >> struct vhost_vring_file file = { }; >> int r; >> >> - net->dev.nvqs = 2; >> - net->dev.vqs = net->vqs; >> - >> r = vhost_dev_enable_notifiers(&net->dev, dev); >> if (r < 0) { >> goto fail_notifiers; >> -- >> 2.25.1 >>